fix(retry): BaseRetryHandler + Make Retry in general easier to play with #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajhorst
reviewed
Mar 17, 2021
| } | ||
|
|
||
| protected _getPayloadOptions(): { options?: PayloadOptions } { | ||
| if (typeof this._options.minIdLength === 'number') { |
There was a problem hiding this comment.
noob typescript question here: if _options is typed as an Options, why specifically check if minIdLength is a number? Or is this a roundabout way of making sure it's not null?
There was a problem hiding this comment.
minIdLength is by default null since it's typed as null | number - if it's not defined, I think it would be better for the HTTP API to decide what the "correct" min ID length is
jooohhn
approved these changes
Mar 30, 2021
| @@ -2,11 +2,16 @@ import { Event } from './event'; | |||
| import { Response } from './response'; | |||
|
|
|||
| /** Layer used to send data to Amplitude while retrying throttled events in the right order. */ | |||
| export interface RetryClass { | |||
| export interface Retry { | |||
There was a problem hiding this comment.
We should remove RetryClass references from README.md
https://github1s.com/amplitude/Amplitude-Node/blob/273/retry-override/packages/node/README.md
There was a problem hiding this comment.
makes a lot of sense, ty! will change
kelvin-lu
force-pushed
the
273/retry-override
branch
from
788939b to
3a9a750
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Begins to address issues highlighted by #86 :
exports
Retrydirectly form@amplitude/nodeso that a second dep isn't necessaryexports
BaseRetryHandlerthat makes it easier to set up a default transport, etc.exports
DefaultTransportExports
RetryClass->Retryin the@amplitude/typesmodule to avoid confusion as this is an interface to implement and not a Class in itself. deprecating and still exportingRetryClassto avoid breaking changes (for now).Checklist