Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrap event pre-processing in try/catch loop to catch potential errors #102

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

kelvin-lu
Copy link
Contributor

Summary

Wrap a line of code into the try/catch loop so that it doesn't cause crashes - begins the process to help #99
Adds a Array.isArray check and also changes a forEach to a for...of for slightly more robustness and performance

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

Copy link
Contributor

@jooohhn jooohhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kelvin-lu kelvin-lu merged commit b1db604 into main Apr 7, 2021
@kelvin-lu kelvin-lu deleted the 273/event-send branch April 7, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants