fix: skip deep link event when url is missing #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelsonpw
approved these changes
Oct 13, 2023
Mercy811
reviewed
Oct 16, 2023
android/src/test/java/com/amplitude/android/plugins/AndroidLifecyclePluginTest.kt
Outdated
Show resolved
Hide resolved
liuyang1520
force-pushed
the
deep-link-event-improve
branch
from
3e2a14e to
4179aa2
Compare
Mercy811
approved these changes
Oct 16, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
## [1.11.2](v1.11.1...v1.11.2) (2023-10-16) ### Bug Fixes * skip deep link event when url is missing ([#150](#150)) ([b8a4a87](b8a4a87))
|
🎉 This PR is included in version 1.11.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix: skip deep link event when url is missing
This PR filters the deep link event (triggered with activity creation) by only limiting to the case when
intent.datais available, this can potentially avoid some noisy.Note this is a breaking change, the existing users will probably see a drop in the event volume, but I think this change aligns more to a bug fix.
Checklist