fix: do not throw NotImplemented error for existing "legacy database"file if the file is not a sqlite file #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file if the file is not a sqlite file
falconandy
force-pushed
the
AMP-83907-data-migration-not-implemented-error
branch
from
5de71e7 to
38d56c5
Compare
android/src/main/java/com/amplitude/android/migration/DatabaseStorage.kt
Show resolved
Hide resolved
1 task
…alid sqlite file for some reason.
justin-fiedler
approved these changes
Sep 13, 2023
justin-fiedler
deleted the
AMP-83907-data-migration-not-implemented-error
branch
github-actions bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
## [1.11.1](v1.11.0...v1.11.1) (2023-09-13) ### Bug Fixes * do not throw NotImplemented error for existing "legacy database"file if the file is not a sqlite file ([#147](#147)) ([3e0b851](3e0b851))
|
🎉 This PR is included in version 1.11.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Possible fix for DataMigration NotImplementedError.
Data migration already checks if the Database file exists and skips the migration if it doesn't.
But if the file exists but it is not a sqlite database for some reason - NotImplemented error is thrown.
Now migration is skipped in both cases.
Checklist