fix: add debug statements when a fragment lifecycle callback is not r…

…egistered
amplitude · Aug 22, 2024 · 70d4924 · 70d4924
1 parent 0baa708
commit 70d4924
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/android/src/main/java/com/amplitude/android/internal/fragments/FragmentActivityHandler.kt b/android/src/main/java/com/amplitude/android/internal/fragments/FragmentActivityHandler.kt
@@ -19,16 +19,16 @@ internal object FragmentActivityHandler {
             val callback = AutocaptureFragmentLifecycleCallbacks(track, logger)
             supportFragmentManager.registerFragmentLifecycleCallbacks(callback, false)
             callbacksMap.getOrPut(this) { mutableListOf() }.add(callback)
-        }
+        } ?: logger.debug("Activity is not a FragmentActivity")
     }
 
-    fun Activity.unregisterFragmentLifecycleCallbacks() {
+    fun Activity.unregisterFragmentLifecycleCallbacks(logger: Logger) {
         (this as? FragmentActivity)?.apply {
             callbacksMap.remove(this)?.let { callbacks ->
                 for (callback in callbacks) {
                     supportFragmentManager.unregisterFragmentLifecycleCallbacks(callback)
                 }
             }
-        }
+        } ?: logger.debug("Activity is not a FragmentActivity")
     }
 }
diff --git a/android/src/main/java/com/amplitude/android/utilities/DefaultEventUtils.kt b/android/src/main/java/com/amplitude/android/utilities/DefaultEventUtils.kt
@@ -174,7 +174,7 @@ class DefaultEventUtils(private val amplitude: Amplitude) {
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP &&
             LoadClass.isClassAvailable(FRAGMENT_ACTIVITY_CLASS_NAME, amplitude.logger)
         ) {
-            activity.unregisterFragmentLifecycleCallbacks()
+            activity.unregisterFragmentLifecycleCallbacks(amplitude.logger)
         }
     }