chore: Add stack traces in exceptions and fix sample app

amplitude · Jan 26, 2024 · 2ea2868 · 2ea2868
1 parent 1ee97e6
commit 2ea2868
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 9 deletions.
diff --git a/core/src/main/java/com/amplitude/core/platform/EventPipeline.kt b/core/src/main/java/com/amplitude/core/platform/EventPipeline.kt
@@ -4,6 +4,7 @@ import com.amplitude.core.Amplitude
 import com.amplitude.core.events.BaseEvent
 import com.amplitude.core.utilities.HttpClient
 import com.amplitude.core.utilities.ResponseHandler
+import com.amplitude.core.utilities.logWithStackTrace
 import kotlinx.coroutines.channels.Channel
 import kotlinx.coroutines.channels.Channel.Factory.UNLIMITED
 import kotlinx.coroutines.channels.consumeEach
@@ -94,9 +95,7 @@ class EventPipeline(
             if (!triggerFlush && message.event != null) try {
                 storage.writeEvent(message.event)
             } catch (e: Exception) {
-                e.message?.let {
-                    amplitude.logger.error("Error when write event: $it")
-                }
+                e.logWithStackTrace(amplitude.logger, "Error when writing event to pipeline")
             }
 
             // Skip flush when offline
@@ -145,9 +144,7 @@ class EventPipeline(
                         amplitude.logger.warn("Event storage file not found: $it")
                     }
                 } catch (e: Exception) {
-                    e.message?.let {
-                        amplitude.logger.error("Error when upload event: $it")
-                    }
+                    e.logWithStackTrace(amplitude.logger, "Error when uploading event")
                 }
             }
         }

diff --git a/core/src/main/java/com/amplitude/core/platform/intercept/IdentifyInterceptor.kt b/core/src/main/java/com/amplitude/core/platform/intercept/IdentifyInterceptor.kt
@@ -8,6 +8,7 @@ import com.amplitude.core.Storage
 import com.amplitude.core.events.BaseEvent
 import com.amplitude.core.events.IdentifyOperation
 import com.amplitude.core.platform.plugins.AmplitudeDestination
+import com.amplitude.core.utilities.logWithStackTrace
 import kotlinx.coroutines.delay
 import kotlinx.coroutines.launch
 import java.util.concurrent.atomic.AtomicBoolean
@@ -107,9 +108,7 @@ class IdentifyInterceptor(
         try {
             storage.writeEvent(event)
         } catch (e: Exception) {
-            e.message?.let {
-                logger.error("Error when write event: $it")
-            }
+            e.logWithStackTrace(logger, "Error when intercepting identifies")
         }
     }
 

diff --git a/core/src/main/java/com/amplitude/core/utilities/LoggerExtensions.kt b/core/src/main/java/com/amplitude/core/utilities/LoggerExtensions.kt
@@ -0,0 +1,12 @@
+package com.amplitude.core.utilities
+
+import com.amplitude.common.Logger
+
+internal fun Exception.logWithStackTrace(logger:Logger, message: String) {
+    this.message?.let {
+        logger.error("$message: $it")
+    }
+    this.stackTrace?.let {
+        logger.error("Stack trace: ${this.stackTraceToString()}")
+    }
+}
diff --git a/samples/java-android-app/src/main/java/com/amplitude/android/sample/MainApplication.java b/samples/java-android-app/src/main/java/com/amplitude/android/sample/MainApplication.java
@@ -84,4 +84,8 @@ public BaseEvent execute(@NonNull BaseEvent event) {
         event.getEventProperties().put("custom android event property", "test");
         return event;
     }
+
+    @Override
+    public void teardown() {
+    }
 }