Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eventType should be required positional param #186

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix: eventType should be required positional param #186

merged 1 commit into from
Apr 8, 2024

Conversation

Mercy811
Copy link
Contributor

@Mercy811 Mercy811 commented Apr 8, 2024 •
edited
Loading

https://amplitude.atlassian.net/browse/AMP-97108

Make the interface less verbose

  • eventType should be required and positional
  • Other class properties are still optional and name parameters
// Before
final event = BaseEvent(eventType: 'event type');

// After
final event = BaseEvent('event type');

@Mercy811 Mercy811 merged commit 1cb1f9b into beta Apr 8, 2024
3 checks passed
@Mercy811 Mercy811 deleted the cleaner-interface branch April 8, 2024 20:05
justin-fiedler pushed a commit that referenced this pull request Apr 8, 2024
@amplitude-sdk-bot
chore(release): 4.0.0-beta.3
963f48d 
# [4.0.0-beta.3](v4.0.0-beta.2...v4.0.0-beta.3) (2024-04-08)

### Bug Fixes

* eventType should be required positional param ([#186](#186)) ([1cb1f9b](1cb1f9b))
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

🎉 This PR is included in version 4.0.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@izaaz izaaz changed the title fix: eventType should be required positional param fix: [AMP-97108] eventType should be required positional param Apr 15, 2024
@izaaz izaaz changed the title fix: [AMP-97108] eventType should be required positional param fix: eventType should be required positional param Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhao900914 yuhao900914 yuhao900914 approved these changes

@justin-fiedler justin-fiedler justin-fiedler approved these changes

@crleona crleona Awaiting requested review from crleona

@izaaz izaaz Awaiting requested review from izaaz

@qingzhuozhen qingzhuozhen Awaiting requested review from qingzhuozhen

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mercy811 @justin-fiedler @yuhao900914