Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update dry run string #180

Merged
merged 4 commits into from
Mar 14, 2024
Merged

ci: update dry run string #180

merged 4 commits into from
Mar 14, 2024

Conversation

Mercy811
Copy link
Contributor

@Mercy811 Mercy811 commented Mar 12, 2024

A stable version release will trigger publish automatically by

- 'v[0-9]+.[0-9]+.[0-9]+*'

To publish a beta version

Copy link
Contributor

@yuhao900914 yuhao900914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should follow the approach we use in the TypeScript repository, which has 2 github actions for different branches release in the main branch. It's very easy to forget and make mistakes to have different workflows in different branches.
Opinions?

@Mercy811
Copy link
Contributor Author

I think we should follow the approach we use in the TypeScript repository, which has 2 github actions for different branches release in the main branch. It's very easy to forget and make mistakes to have different workflows in different branches.
Opinions?

Hi @yuhao900914, I am taking this differently.

  • It's more flexible and clean to allow select a branch. TypeScript repo has three different CI yml files (publish-v1.yml, publish-v2.yml, and feature-branch-prerelease.yml) because of not being able to select branch.
  • To avoid making mistakes, always run dry run first.
    wdyt?

@Mercy811
Copy link
Contributor Author

Thanks @justin-fiedler for jumping into a sync:

@Mercy811 Mercy811 changed the title ci: enable dry run when publish ci: update dry run string Mar 13, 2024
@Mercy811 Mercy811 merged commit 21c7f09 into beta Mar 14, 2024
5 checks passed
@Mercy811 Mercy811 deleted the update-publish-ci branch March 14, 2024 17:46
Copy link

github-actions bot commented Apr 3, 2024

🎉 This PR is included in version 4.0.0-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants