Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/path.py - fix GIT_REPO_REGEX and calc_repo_path #172

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

kkozik-amplify
Copy link
Contributor

@kkozik-amplify kkozik-amplify commented Oct 19, 2023

When running tf init, terrawrap wasn't able to match regex to my remotes (both SSH and HTTPS).
Turns out my git installation is translated to polish, so git remote show origin -n shows
Adres do pobierania: https://github.com/amplify-education/terraform-config.git
instead of
Fetch URL https://github.com/amplify-education/terraform-config.git
The regex is looking for the URL phrase which is absent in my case, hence the issue.

@kkozik-amplify kkozik-amplify force-pushed the fix/calc_repo_path_regex branch from 6c6f810 to bbf3244 Compare October 19, 2023 10:36
@kkozik-amplify kkozik-amplify marked this pull request as ready for review October 19, 2023 11:24
@kkozik-amplify kkozik-amplify requested a review from a team October 19, 2023 11:24
rddimon
rddimon previously approved these changes Oct 19, 2023
@kkozik-amplify kkozik-amplify force-pushed the fix/calc_repo_path_regex branch from 30226b3 to 2adb8e2 Compare October 23, 2023 09:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@amplify-self-hosted-runners
Copy link

Check Name Conclusion Summary Output
SonarCloud Code Analysis success Quality Gate passed output
pre-commit success pre-commit output
Verify that version was updated success Verify that version was updated output
Check code against linter/unit tests (3.7) success Check code against linter/unit tests (3.7) output
Check code against linter/unit tests (3.8) success Check code against linter/unit tests (3.8) output
Check code against linter/unit tests (3.9) success Check code against linter/unit tests (3.9) output
SonarCloud success No new alerts in code changed by this pull request output

@kkozik-amplify kkozik-amplify merged commit 58da07a into main Oct 23, 2023
8 checks passed
@kkozik-amplify kkozik-amplify deleted the fix/calc_repo_path_regex branch October 23, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants