View methods to preview rewards #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aalavandhan
commented
Nov 28, 2024
•
aalavandhan
commented
- Remove the reward calculation logic from update accounting
- Added a separate previewRewards view method
- Added method to view unlock time schedule
aalavandhan
commented
Nov 28, 2024
aalavandhan
force-pushed
the
preview-methods
branch
5 times, most recently
from
e4c5634 to
05cdd60
Compare
aalavandhan
force-pushed
the
preview-methods
branch
2 times, most recently
from
c6af76d to
2f6e2b2
Compare
aalavandhan
changed the title
aalavandhan
force-pushed
the
preview-methods
branch
from
2f6e2b2 to
29b6a5e
Compare
brandoniles
reviewed
Dec 3, 2024
| * @return Updated amount of distribution tokens to award, with any bonus included on the | ||
| * newly added tokens. | ||
| */ | ||
| function computeNewReward( | ||
| uint256 currentRewardTokens, | ||
| uint256 stakingShareSeconds, | ||
| uint256 stakeTimeSec | ||
| uint256 totalStakingShareSeconds_, |
There was a problem hiding this comment.
Do we need to send this in, when there's already a contract variable for it we could read from?
I assume it's to support hypothetical queries from the front end. Just want to make sure there's a use case for it, since it's a bit of a code smell to have this copied / naming conflict / etc.
There was a problem hiding this comment.
We need to send this in when we run the preview. Because, totalStakingShareSeconds wouldn't have yet been committed on-chain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.