Refactor #22
Merged
Refactor #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandoniles
reviewed
Nov 14, 2024
nms-7
approved these changes
Nov 15, 2024
contracts/TokenGeyser.sol
Outdated
| lastAccountingTimestampSec = block.timestamp; | ||
|
|
||
| // User Accounting | ||
| UserTotals storage totals = userTotals[msg.sender]; |
There was a problem hiding this comment.
nit: consider renaming totals to something like user. current naming is a little awkward later on when calculating totalUserRewards using totals.stakingShareSeconds as user's values, and totalStakingShareSeconds as total
brandoniles
approved these changes
Nov 19, 2024
| @@ -9,7 +9,7 @@ import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol"; | |||
| interface ITokenGeyser { | |||
| function stake(uint256 amount) external; | |||
| function unstake(uint256 amount) external returns (uint256); | |||
| function totalStakedFor(address addr) external view returns (uint256); | |||
| function totalStakedBy(address addr) external view returns (uint256); | |||
There was a problem hiding this comment.
I like the name change, but flagging that it would mean changes for the frontend. Assuming it would need to be smart enough to know which contract version it's talking to on the backend.
There was a problem hiding this comment.
Right. I think for the new frontend we shouldn't expect backward compatibility with OG v1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up interface and added upgradability