Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vault Refactor & Meta Oracle #224

Merged
merged 6 commits into from
Nov 11, 2024
Merged

Vault Refactor & Meta Oracle #224

merged 6 commits into from
Nov 11, 2024

Conversation

aalavandhan
Copy link
Member

@aalavandhan aalavandhan commented Sep 16, 2024 •
edited
Loading

  • New unified pricer / meta oracle (which is used by bill broker and the charm vaults)
  • Updated bill broker to use the new pricer, some code clean up
  • Updated charm vault managers to use the new pricer, some code clean up
  • Updated test suite

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Sep 16, 2024 •
edited
Loading

Vault Refactor & Meta Oracle

Generated at commit: b7a1008b51b1098ec0fa11517126ce72194d5370

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 1
0
0
3
23
27
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@aalavandhan aalavandhan force-pushed the appraiser-fix branch 3 times, most recently from 6cd9f05 to 0fcd00d Compare September 17, 2024 23:42
@aalavandhan aalavandhan force-pushed the charm-pricer branch 2 times, most recently from aabfa9a to a28966f Compare September 18, 2024 02:09
@aalavandhan aalavandhan changed the title Charm pricer Charm vaults use new pricer (meta oracle) Oct 29, 2024
@aalavandhan aalavandhan mentioned this pull request Nov 6, 2024
Closed
@aalavandhan aalavandhan changed the base branch from appraiser-fix to main November 6, 2024 01:50
@aalavandhan aalavandhan changed the title Charm vaults use new pricer (meta oracle) Vault Refactor & Meta Oracle Nov 6, 2024
@aalavandhan aalavandhan force-pushed the charm-pricer branch 3 times, most recently from 5f9abfc to 56a002d Compare November 7, 2024 01:17
brandoniles
brandoniles reviewed Nov 8, 2024
View reviewed changes
spot-vaults/contracts/_strategies/SpotPricer.sol Outdated Show resolved Hide resolved
spot-vaults/contracts/_strategies/SpotPricer.sol Outdated Show resolved Hide resolved
spot-vaults/contracts/_strategies/SpotPricer.sol Outdated Show resolved Hide resolved
spot-vaults/contracts/_strategies/SpotPricer.sol Outdated Show resolved Hide resolved
spot-vaults/contracts/_interfaces/IMetaOracle.sol Outdated Show resolved Hide resolved
spot-vaults/contracts/BillBroker.sol Show resolved Hide resolved
brandoniles
brandoniles approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@brandoniles brandoniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalavandhan aalavandhan merged commit 62c5fb4 into main Nov 11, 2024
1 check passed
@aalavandhan aalavandhan deleted the charm-pricer branch November 11, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandoniles brandoniles brandoniles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aalavandhan @brandoniles