This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Allow replacing old value in MarketOracle even if last push was less than reportDelaySec ago #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahnaguib
changed the title
aalavandhan
reviewed
Sep 11, 2020
| @@ -77,7 +77,8 @@ contract('MedianOracle:pushReport', async function (accounts) { | |||
| expect(await chain.isEthException(oracle.pushReport(1000000000000000000, { from: A }))).to.be.true; | |||
| oracle.addProvider(A, { from: deployer }); | |||
| r = await oracle.pushReport(1000000000000000000, { from: A }); | |||
| // should fail if reportDelaySec did not pass since the previous push | |||
| r = await oracle.pushReport(1000000000000000000, { from: A }); | |||
There was a problem hiding this comment.
can we create a separate test for this case?
I think the original test is should only push from authorized source
There was a problem hiding this comment.
Will be great if we can test all the cases:
Reported rates (ordered by time) are r1, r2. The new rate is r.
- r2 < minValidTimestamp
- r1 < minValidTimestamp < r2 < maxValidTimestamp
- minValidTimestamp < r1 < r2 < maxValidTimestamp
- r1 < minValidTimestamp < maxValidTimestamp < r2
- minValidTimestamp < r1 < maxValidTimestamp < r2
- maxValidTimestamp < r1
Am I missing something?
There was a problem hiding this comment.
will make sure at least coverage is back to 100%
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.