Remove emit ReportTimestampOutOfRange so getData is read only #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove emit ReportTimestampOutOfRange so getData is read only
Remove emit ReportTimestampOutOfRange so getData is read only
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
aalavandhan
approved these changes
Aug 21, 2024
|
Yea. Good call. Was meaning to do this too. |
aalavandhan
approved these changes
Aug 21, 2024
| @@ -186,10 +186,10 @@ contract MedianOracle is OwnableUpgradeable, IOracle { | |||
| .timestamp; | |||
| if (reportTimestampPast < minValidTimestamp) { | |||
| // Past report is too old. | |||
| emit ReportTimestampOutOfRange(providerAddress); | |||
| // Deprecated: emit ReportTimestampOutOfRange(providerAddress); | |||
There was a problem hiding this comment.
I think we can just remove it, rather than commenting it out. Dont think any of our off-chain services rely on this log.
There was a problem hiding this comment.
I think it is a good idea to leave so that previous logs are still understandable
brandoniles
reviewed
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove emit ReportTimestampOutOfRange so getData is read only