Orchestrator whitelist #253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalavandhan
reviewed
May 4, 2023
| @@ -22,6 +22,8 @@ contract Orchestrator is Ownable { | |||
| // Stable ordering is not guaranteed. | |||
| Transaction[] public transactions; | |||
|
|
|||
| address[] private whitelist; | |||
There was a problem hiding this comment.
Maybe use EnumerableSet here, so we don't have to loop through the list to check existence every time?
EnumerableSet is a little more expensive on write though (uses 2 slots instead of 1)
aalavandhan
reviewed
May 4, 2023
| @@ -42,7 +44,24 @@ contract Orchestrator is Ownable { | |||
| */ | |||
| function rebase() external { | |||
| require(msg.sender == tx.origin); // solhint-disable-line avoid-tx-origin | |||
There was a problem hiding this comment.
We could just have one rebase function but add a modifier where we check if either msg.sender == tx.origin or msg.sender is part of the whitelist
|
We could also update the orchestrator to the latest solidity version as we do this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds whitelist to orchestrator contract so that whitelisted contracts can call rebase