✨ Apple Silicon (arm64) support, fixes #36 #54
Conversation
AndreMiras
force-pushed
the
feature/version_bump_and_apple_arm64_support
branch
from
760870f
to
b368541
Compare
Note that we (cross) compile for both arm64 and the universal2. This may feel redundant, it can still be interesting to have both. While universal2 is more convenient arm64 is lighter. Also drop Python 3.7 (end-of-life 2023-06-27). Add Python 3.12 and pypy-3.10 support. Bump CI actions versions as well.
AndreMiras
force-pushed
the
feature/version_bump_and_apple_arm64_support
branch
from
b368541
to
863c94e
Compare
| @@ -1,16 +1,19 @@ | |||
| name: Tests | |||
|
|
|||
| on: [push] | |||
| on: [push, pull_request] | |||
There was a problem hiding this comment.
Also sneaked that change in so we would have caught that issue earlier:
#49 (comment)
| on: [push, pull_request] | ||
|
|
||
| env: | ||
| PYTHON_VERSIONS: ["3.8", "3.9", "3.10", "3.11", "3.12", "pypy-3.8", "pypy-3.9", "pypy-3.10"] |
There was a problem hiding this comment.
DRY fix, but also removed 3.7, and added 3.12 as well as pypy-3.10.
But if we prefer I can address these changes in another dedicated PR
| CIBW_ARCHS_MACOS: x86_64 arm64 universal2 | ||
| CIBW_TEST_REQUIRES: .[test] | ||
| CIBW_TEST_COMMAND: pytest {project} | ||
| # arm64 cannot be tested on a x86_64 CI runner | ||
| CIBW_TEST_SKIP: "*-macosx_arm64" |
There was a problem hiding this comment.
This is the macOS arm64 support part, all the rest of the PR is just chore
|
Hi @amitdev, how can I help you merge this one? |
|
Thanks @AndreMiras for the PR. I was away for sometime so couldn't get this merged. Will get a release out soon. |
|
@AndreMiras can you fix this issue with tests btw? If not I'll take a look when I get time later: |
|
OK I was confused how I missed that one, but it's clear now. Since the workflow had a syntax error it didn't even run so the PR was still marked green. |
It seems like we can't use env in stragegy.matrix, refs: - https://github.com/orgs/community/discussions/56787 - amitdev#54 (comment)
|
Here's the fix #55, thanks for the heads up. |
It seems like we can't use env in stragegy.matrix, refs: - https://github.com/orgs/community/discussions/56787 - amitdev#54 (comment)
Note that we (cross) compile for both arm64 and the universal2. This may feel redundant, it can still be interesting to have both. While universal2 is more convenient arm64 is lighter.
Also drop Python 3.7 (end-of-life 2023-06-27).
Add Python 3.12 and pypy-3.10 support.
Bump CI actions versions as well.