fix: the variable reference + docs for relation with ENABLE_VCPKG_UPDATE

aminya · Jul 15, 2022 · 5bc9eda · 5bc9eda
1 parent 00ac0f5
commit 5bc9eda
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -253,8 +253,10 @@ run_vcpkg(
 
 Named Option:
 
-- `ENABLE_VCPKG_UPDATE`: (Disabled by default). If enabled, the vcpkg registry is updated before building (using `git pull`). As a result, if some of your vcpkg dependencies have been updated in the registry, they will be rebuilt.
-Not that If `VCPKG_REV` is checked out after pulling the vcpkg repository.
+- `ENABLE_VCPKG_UPDATE`: (Disabled by default). If enabled, the vcpkg registry is updated before building (using `git pull`).
+
+  If `VCPKG_REV` is set to a specific commit sha, no rebuilds are triggered.
+  If `VCPKG_REV` is not specified or is a branch, enabling `ENABLE_VCPKG_UPDATE` will rebuild your updated vcpkg dependencies.
 
 Named String:
 

diff --git a/src/Vcpkg.cmake b/src/Vcpkg.cmake
@@ -64,7 +64,7 @@ macro(run_vcpkg)
   endif()
 
   if(NOT
-     "_vcpkg_args_VCPKG_REV"
+     "${_vcpkg_args_VCPKG_REV}"
      STREQUAL
      "")
     find_program(GIT_EXECUTABLE "git" REQUIRED)