-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI/CD workflow #2
Conversation
After the upstream fix robotology-legacy/gym-ignition#234, the sdist gets compiled successfully, but the test fails when runs in the workflow. Locally instead it works fine. |
I managed to reproduce the failure in a local docker image:
Yet another time, problems with protobuf 😑 I think that the problem is that the I'm almost done with robotology-legacy/gym-ignition#230, and in Focal it seems we no longer need to use a custom protobuf version for tensorflow compatibility (just the import order in Python is important). I'll leave this PR pending waiting to update upstream to Focal. I think that also the problem we experienced in robotology-legacy/gym-ignition#76 was the same as here. |
5d9b4f4
to
404e1e9
Compare
I did some tests but even after packaging This is totally ok if no other libraries try to load another version of protobuf. Unfortunately, this is the case of plugin libraries like those provided by this repo. In fact, the error reported above occurs not when I don't have many ideas, I tried to tweak a bit the dlopen flags from Python but I didn't find any working configuration. At this point I will leave this PR pending (again) waiting that our changes land upstream. |
Whoah, the situation feels intricated. Yes, probably waiting for switching everything to Focal make sense. More in general, this show the shortcoming of using a distribution system that does not deal explicitly with binary C/C++ dependencies. In the long term, using something like conda could be beneficial to deal with this problems. However, I am afraid that on Python there is no silver bullet, especially when dealing with Tensorflow, as for example Tensorflow 2 is still not packaged for conda-forge, see conda-forge/tensorflow-feedstock#70 . |
I am still hesitant to switch to systems like conda-forge because it could be problematic each time we need to use a package that is not yet part of it (e.g. ray-project/ray#585). It's interesting and worth keeping an eye on it, but I suspect that it's not as mature as we require (and note we're quite prone to use modern technologies like focal / python3.8 / C++17, ...). |
d37391a
to
623b265
Compare
f1c93fc
to
e999ba3
Compare
sq setup
3731aaa
to
b58c33f
Compare
Closes #1.
This PR add a new GitHub workflow to package, install, test, and publish to PyPI the
sdist
package. This time I am experimenting PEP517 and PEP518 support.Few resources: