Add FloatingBaseEstimatorDevice YARP wrapper to the algorithms in FloatingBaseEstimator library #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashanthr05
commented
Oct 21, 2020
7 tasks
prashanthr05
requested review from
GiulioRomualdi,
S-Dafarra and
HosameldinMohamed
prashanthr05
force-pushed
the
device/FloatingBaseEstimator
branch
2 times, most recently
from
17eb96e to
4e1a6f6
Compare
S-Dafarra
reviewed
Nov 12, 2020
S-Dafarra
reviewed
Nov 12, 2020
devices/FloatingBaseEstimatorDevice/src/FloatingBaseEstimatorDevice.cpp
Outdated
Show resolved
Hide resolved
devices/FloatingBaseEstimatorDevice/src/FloatingBaseEstimatorDevice.cpp
Outdated
Show resolved
Hide resolved
devices/FloatingBaseEstimatorDevice/src/FloatingBaseEstimatorDevice.cpp
Outdated
Show resolved
Hide resolved
prashanthr05
force-pushed
the
device/FloatingBaseEstimator
branch
from
ebe68e4 to
4454ca8
Compare
S-Dafarra
reviewed
Nov 16, 2020
prashanthr05
force-pushed
the
device/FloatingBaseEstimator
branch
from
fe323bd to
553b80a
Compare
S-Dafarra
approved these changes
Nov 19, 2020
|
Feel free to push the merge button! |
prashanthr05
force-pushed
the
device/FloatingBaseEstimator
branch
from
553b80a to
900d57c
Compare
Thanks! @GiulioRomualdi would you have any comments before I merge? |
GiulioRomualdi
approved these changes
Nov 19, 2020
There was a problem hiding this comment.
@GiulioRomualdi would you have any comments before I merge?
I trust @S-Dafarra. @prashanthr05 please feel free to merge it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a YARP device wrapper for the FloatingBaseEstimator library, in its current version implementing an InvariantEKF.
Remark for reviewers:
Mostly contains small files for configuration and scopes.
Only two files for the source code are significantly big.