feat: remove enzyme support #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: enzyme adapter and serializer must now be configured independently if needed
smackfu
commented
Feb 5, 2024
| ### Compatibility | ||
|
|
||
| This package is compatible only with React 16+. |
There was a problem hiding this comment.
This actually changed with the last major version which switched to the enzyme 17 adapter.
|
Closing since it seems like the preference is to use the react-18 adapter despite it's limitations. |
|
Reopening as the inclusion of the enzyme adapter was a stop gap. Support will only drift further apart. |
JAdshead
pushed a commit
that referenced
this pull request
Feb 17, 2024
BREAKING CHANGE: enzyme adapter and serializer must now be configured independently if needed
oneamexbot
added a commit
that referenced
this pull request
Feb 17, 2024
# [9.0.0](v8.1.0...v9.0.0) (2024-02-17) ### chore * **node:** drop node 16 support ([2ec5125](2ec5125)) ### Features * **peer-deps:** allow react 18 ([db79ec5](db79ec5)) * remove enzyme support ([#72](#72)) ([24ed427](24ed427)) ### BREAKING CHANGES * **node:** drop node 16 support * enzyme adapter and serializer must now be configured independently if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: enzyme adapter and serializer must now be configured independently if needed
Description
Remove the enzyme dependency and configuration.
Motivation and Context
enzyme is not supported in React 18.
https://dev.to/wojtekmaj/enzyme-is-dead-now-what-ekl
It's also no longer considered good testing practice vs something like react-testing-library.
The enzyme dependency and configuration in this preset makes it hard to move completely away from enzyme.
(I don't think this can be moved to an optional peer dep because of the references to enzyme in the jest config.)
How Has This Been Tested?
Installed in a package that otherwise doesn't use enzyme and verified that unit tests still pass and does not bring in the dependency.
Types of Changes
Checklist:
What is the Impact to Developers Using amex-jest-preset-react?
Upgrading to the new version would require manually configuration enzyme if it is still being used.