Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multi-dimensional ArrayVar declaration #25

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

rmshaffer
Copy link
Contributor

@rmshaffer rmshaffer commented Jun 4, 2024

Issue #, if available:
#13, follow-up to PR #22

Description of changes:
Fix implementation and test for multi-dimensional ArrayVar declaration.

Testing done:
tox passes.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rmshaffer rmshaffer marked this pull request as ready for review June 4, 2024 20:05
@rmshaffer rmshaffer requested a review from a team as a code owner June 4, 2024 20:05
@rmshaffer rmshaffer changed the title Fix multi-dimensional ArrayVar declaration fix: multi-dimensional ArrayVar declaration Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (90c2bbd) to head (4914208).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        43           
  Lines         1906      1907    +1     
  Branches       320       320           
=========================================
+ Hits          1906      1907    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rmshaffer
Copy link
Contributor Author

@Yash-10 please take a look if you can, this is a quick follow-up to your PR #22.

@Yash-10
Copy link
Contributor

Yash-10 commented Jun 5, 2024

Thanks, @rmshaffer, for these changes and for fixing the small issue from my PR! I think this makes more sense.

@jcjaskula-aws jcjaskula-aws self-requested a review June 5, 2024 12:54
Copy link
Contributor

@jcjaskula-aws jcjaskula-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmshaffer rmshaffer merged commit 62ab4c5 into main Jun 5, 2024
15 checks passed
@rmshaffer rmshaffer deleted the rmshaffer/multi-dim-array branch June 5, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants