Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add IQM Garnet device, retire OQC Lucy device #93

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

rmshaffer
Copy link
Contributor

@rmshaffer rmshaffer commented Jul 2, 2024

Issue #, if available:

Description of changes:
Mark OQC Lucy device with _ prefix since it is now retired from the Braket service. Add IQM Garnet device which recently launched.

Testing done:
julia -e 'using Pkg; Pkg.test("Braket")'

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have installed and run git secrets to make sure I did not commit any sensitive information (passwords or credentials)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rmshaffer rmshaffer marked this pull request as ready for review July 2, 2024 13:50
@rmshaffer rmshaffer requested a review from kshyatt-aws July 2, 2024 13:50
test/schemas_misc.jl Outdated Show resolved Hide resolved
Copy link
Member

@kshyatt-aws kshyatt-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to add some docs for the new device too but otherwise LGTM

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.00%. Comparing base (06f2594) to head (20139d2).

Files Patch % Lines
src/device.jl 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   89.04%   89.00%   -0.04%     
==========================================
  Files          36       36              
  Lines        3915     3929      +14     
==========================================
+ Hits         3486     3497      +11     
- Misses        429      432       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rmshaffer
Copy link
Contributor Author

Waiting for #92 to be merged to fix the PyBraket-unit CI issues.

@rmshaffer rmshaffer merged commit c998090 into main Jul 3, 2024
17 of 20 checks passed
@rmshaffer rmshaffer deleted the rmshaffer/remove-oqc branch July 3, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants