Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: Only test on new LTS and above #105

Merged
merged 2 commits into from
Oct 9, 2024
Merged

change: Only test on new LTS and above #105

merged 2 commits into from
Oct 9, 2024

Conversation

kshyatt-aws
Copy link
Contributor

Issue #, if available: N/A

Description of changes: Julia 1.10 is the new LTS, so we can be frugal and drop support for older versions in CI.

Testing done: N/A

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have installed and run git secrets to make sure I did not commit any sensitive information (passwords or credentials)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kshyatt-aws kshyatt-aws requested a review from a team as a code owner October 9, 2024 16:18
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.98%. Comparing base (2efe7c3) to head (4219ef8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   88.94%   87.98%   -0.97%     
==========================================
  Files          36       36              
  Lines        3981     3979       -2     
==========================================
- Hits         3541     3501      -40     
- Misses        440      478      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kshyatt-aws kshyatt-aws force-pushed the ksh/lts branch 2 times, most recently from efb974b to 01bca3d Compare October 9, 2024 18:19
@kshyatt-aws kshyatt-aws requested a review from rmshaffer October 9, 2024 19:35
@kshyatt-aws kshyatt-aws merged commit 1716cfc into main Oct 9, 2024
12 of 14 checks passed
@kshyatt-aws kshyatt-aws deleted the ksh/lts branch October 9, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants