-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for symbolic expressions in FreeParameters #82
Comments
Hi @kshyatt-aws , Sounds Interesting! I would like to work on this issue. Should I include the Line 129 in 1d05da0
|
Yes, I think that would make sense, because |
Hi, @kshyatt-aws, Please let me know that the output looks something like this: I have used α + 2θ as FreeParameterExpression
I was spending time with reading the guidelines. Shall I open a PR now? |
Yes, something like this would be great. You might want to consider using |
Hi, @kshyatt-aws, Please assign the issue to me after closing it! 😬 All suggestions have been incorporated 🙏🏼 ! |
Hi, Please assign the closed issue. Thanks. |
The Please see that the |
* Feature: Adding support for FreeParameterExpression, resolving Issue #82 * [Feature]: Adding support for FreeParameterExpression: Improving tests and subs function * [Feature]: Adding support for FreeParameterExpression - minor cleanup * [Feature]: Adding support for FreeParameterExpression - Formatting * [Feature]: Adding support for FreeParameterExpression - Adding codereview suggestions * [Feature]: Adding support for FreeParameterExpression - completing codereview suggestions * [Feature]: Adding support for FreeParameterExpression - direct gate generation example to doctests * [Feature]: Adding support for FreeParameterExpression - formatting * [Feature]: Adding support for FreeParameterExpression - formatting * [Feature]: Adding support for FreeParameterExpression - Adding more tests * [Feature]: Adding support for FreeParameterExpression - formatting * sliming down the operator functions * codereview suggestions * Minor Formatting, Including complete Greek Letters * fix Symbolic version to 5.30.0 and SymbolicUtils to 2.0.2 * using SymbolicUtils = =2.0.2 --------- Signed-off-by: Katharine Hyatt <[email protected]> Co-authored-by: Fe-r-oz <[email protected]> Co-authored-by: Katharine Hyatt <[email protected]>
Describe the feature you'd like
Currently only numerical values are allowed for
FreeParameter
. We should replicate the Python SDK support forFreeParameterExpression
, allowing gates likeRx( 2 * alpha /3)
, for example.Is this feature already present in the Python SDK?
Yes. https://github.com/amazon-braket/amazon-braket-sdk-python/blob/main/src/braket/parametric/free_parameter_expression.py
How would this feature be used? Please describe.
This would allow more complex expressions for parametrized gates.
Describe alternatives you've considered
Currently users have to create new parameters to capture cases like
2 * alpha
.Additional context
An appropriate Julia package should be chosen for the symbolic expressions.
SymbolicExpressions.jl
is one example.The text was updated successfully, but these errors were encountered: