This repository has been archived by the owner on Aug 8, 2024. It is now read-only.
fix bug with regex matching when using Python 3 #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Python 3+, the ff error is generated:
Python 3+ will return the
log_line
as a bytes-like object , which will not a compatible with the method signature.My proposed fix detects if the version of Python is 3+ and then decodes it into utf-8 as necessary.
Fixes #18 and makes the code work as expected on Python 3+.