Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Update for Play Services Cast framework #671

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Added Update for Play Services Cast framework #671

merged 1 commit into from
Sep 9, 2020

Conversation

Akash-Ramjyothi
Copy link
Member

Description:

Added update for the play services cast framework from version 11.6.0 to 12.0.0.

@chirag-jn
Copy link
Member

Have you tried using Google Cast? While updating the library version, it would be great if you can specify the change introduced by the library.

@chirag-jn
Copy link
Member

https://developers.google.com/android/guides/releases
The latest play-services-cast-framework library version is 19.0

@cpg
Copy link
Member

cpg commented Sep 7, 2020

I vaguely recall we discussed we had some issue about going beyond v12?

@Akash-Ramjyothi
Copy link
Member Author

Akash-Ramjyothi commented Sep 8, 2020

Updating the library to version 19.0 immediately caused errors as I tested. This pointed an error on the file AmahiModule.java. This is because we are going beyond v12 as @cpg mentioned. Version 12.0 is the compatible version of this library.

@chirag-jn
Copy link
Member

Can you mention the error here?

@Akash-Ramjyothi
Copy link
Member Author

If needed to implement version 19.0, I will make a new PR specifying and solving the injecting error on AmahiModule.java. This PR just updates it to a stable version i.e. 12.0 as specified in the first description.

@chirag-jn
Copy link
Member

Beyond Version 12, play-services-cast-framework requires you to use Dagger 2 instead of Dagger 1. So as soon as issue #597 is resolved, we can update to the latest cast library version.

@Akash-Ramjyothi
Copy link
Member Author

Akash-Ramjyothi commented Sep 8, 2020

That is a good solution. I strongly agree with you. But for the time being, you suggest to merge it or close it?

@chirag-jn
Copy link
Member

That is a good solution. I strongly agree with you. But for the time being, you suggest to merge it or close it?

Merge

@cpg
Copy link
Member

cpg commented Sep 9, 2020

Thanks for the details. Hopefully we can get around to implementing a move to dagger 2 soon.

@cpg cpg merged commit 0f7c148 into amahi:beta Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants