Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace DF with DB #42

Merged
merged 6 commits into from
Jul 18, 2024
Merged

Replace DF with DB #42

merged 6 commits into from
Jul 18, 2024

Conversation

PhictionalOne
Copy link
Collaborator

No description provided.

@PhictionalOne PhictionalOne requested a review from am9zZWY July 18, 2024 08:48
@PhictionalOne
Copy link
Collaborator Author

@am9zZWY Kannst du die Rank als Pipeline stufe umschreiben? Bzw. ich brauch nen weg da die DB connection reinzuklemmen. Und gerade ist das alles disjunkt.

Bzw. fällt dir was auf?

@am9zZWY
Copy link
Owner

am9zZWY commented Jul 18, 2024

Kannst du die Rank als Pipeline stufe umschreiben?

Wir könnten ne Ranker Klasse hinzufügen, die halt einfach nen Zustand, etwa ne Db-Verbindung besitzt, und ein paar Instanz-Methoden, um zu ranken @okihnjo @lu391see @PhictionalOne?

This was linked to issues Jul 18, 2024
@am9zZWY am9zZWY merged commit 5acc686 into master Jul 18, 2024
1 check passed
@am9zZWY am9zZWY deleted the phi-crawl-to-db branch July 19, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save webpage for DuckDB analysis Integrate DuckDB
2 participants