Upgrade Eslint to v9 #204
Merged
Upgrade Eslint to v9 #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattIPv4
requested changes
Dec 11, 2024
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 suggestion.
Files not reviewed (1)
- package.json: Language not supported
Comments skipped due to low confidence (2)
eslint.config.js:2
- [nitpick] The import alias 'tseslint' is inconsistent with the package name 'typescript-eslint'. Consider renaming it to 'typescriptEslint' for clarity.
import tseslint from "typescript-eslint";
eslint.config.js:4
- [nitpick] The import alias 'eslintPluginPrettierRecommended' is unnecessarily verbose. Consider renaming it to 'prettierRecommended' for brevity.
import eslintPluginPrettierRecommended from "eslint-plugin-prettier/recommended";
MattIPv4
reviewed
Dec 11, 2024
MattIPv4
reviewed
Dec 12, 2024
|
@MattIPv4 I couldn't pick this up again today, but will look into it this ASAP. I'll use the main website's implementation as basis for the next iteration. |
|
No worries, and thank you! |
added 4 commits
December 16, 2024 23:10
…fig a esmodule file. Clean up eslint command.
guilherme-andrade
force-pushed
the
upgrade-eslint-to-v9
branch
from
87acf47 to
00e0c0f
Compare
|
FYI if you're interested, alveusgg/data also has an eslint config that needs upgrading ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Came across the repo and decided to open this :) Upgrades Eslint to v9, maintaining the same configuration while using the new flat config syntax.
Resolves #185, closes #201