-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to override request #99
base: master
Are you sure you want to change the base?
Added option to override request #99
Conversation
@@ -62,6 +62,9 @@ const sharedQuerySchema = Joi.object({ | |||
'screenshot.clip.width': Joi.number(), | |||
'screenshot.clip.height': Joi.number(), | |||
'screenshot.omitBackground': Joi.boolean(), | |||
// 'request.headers': Joi.object(), // any way to send an object? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if there are any clever workarounds here. Could optionally be a json string that gets decoded? I think #78 has this same issue.
Thanks for the contribution. I think this is a great idea. I don't have currently time to help with this but I like the idea of having full control to the request. It opens up even easier ways to exploit this service to make requests to internal services etc, but that's what the API_KEY is for. |
I have a fork of this project I maintain for an internal app my company has. I've had to modify this so that it allows a JSON POST body that the app will make rather than. I added a field called This doesn't look like it's gotten any traction, but I'd love to see this merged into the project as otherwise I have to maintain a constantly-rebased fork. |
its not make sense create a service that we cant pass a authorization to it. Why not accept the pr? its just a simple thing... |
For those who are looking for a tool that has this feature, I've been using this micro-service with great success. I think if the authors don't wish to add it, that is fine. The whole point of open source stuff is we can fix it/add it ourselves or swap it out. |
This change allows overriding the request, so you can render a page that uses a post request.
Example: