Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Latest Dependency Updates #4375

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Conversation

machineFL
Copy link
Collaborator

This is an auto-generated PR with latest dependency updates.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0073d5f) 99.7% compared to head (9630105) 99.7%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4375   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        357     357           
  Lines      39922   39922           
=====================================
  Hits       39796   39796           
  Misses       126     126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@machineFL machineFL requested a review from eccabay December 22, 2023 14:02
@machineFL machineFL force-pushed the latest-dep-update-0073d5f branch 2 times, most recently from d91cafd to 5736a78 Compare December 24, 2023 23:02
@machineFL machineFL force-pushed the latest-dep-update-0073d5f branch from 5736a78 to 067bee6 Compare December 27, 2023 03:02
@MichaelFu512
Copy link
Contributor

MichaelFu512 commented Dec 27, 2023

From a quick look at the test, it looks like something from the sktime upgrade caused an issue.

Edit: Looks like there were changes to sktime's transformations/base.py. Originally, the check to see if "X must be in an sktime compatible format" was before this declaration:X_scitype = X_metadata["scitype"]. I'm assuming normally it would raise an error and exit before it got to the declaration.

Now it looks like that declaration is before the check, causing a "'NoneType' object is not subscriptable" error since X_metadata is None for that test.

Looks like that change happened in v0.24.2

@MichaelFu512 MichaelFu512 merged commit 4c782a7 into main Dec 27, 2023
27 checks passed
@MichaelFu512 MichaelFu512 deleted the latest-dep-update-0073d5f branch December 27, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants