Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Woodwork 0.17.2 compatibility :( #3626
Woodwork 0.17.2 compatibility :( #3626
Changes from all commits
c41d1de
3b18083
97157e0
6dfd577
5bbf65d
70d038c
43ece37
638705d
4e47f78
a3aa645
7cdeb1d
b50ad59
c0a7566
ca24080
a55ec4f
e294000
c69ec06
263b9a0
54ec0cc
625681b
bbb6820
2a92d38
79cb5c7
3c1ebee
3bc8191
a6db357
573fc6f
e6363aa
35435f8
dc61825
b661aab
d261e71
b95b3d6
33b8a9e
ea97418
7852c11
3ebbafd
0341777
50ccf33
8ebcb48
798d2e7
ee88e89
dd21c9a
e9aec48
0b0cd59
dde9c77
b94bb37
63c3168
7a8ba71
664e4f9
9acd1bc
9db71c0
7d78f9f
dda2b05
2db0718
2a1b8b8
ec47fc2
426ed33
21d987d
3cde5c4
7b81eb3
187d7ff
9c64c4c
9b5d73c
3d6cc07
b42dff0
c23443e
8227596
cd9ff14
2812e99
e920710
e029d15
4f8eb17
654ca9b
a8039a6
1ec5aee
7f27e49
8dbf0d5
3c734b0
c5fc0b5
3904a3c
295e701
6c5bd5d
6132cb2
71a367c
649bc33
82ae057
c325c39
4579127
7325a4d
1b7434e
b95207a
969eba3
dd1346b
860ba3a
ce7af81
e3649ad
dff1c4a
f324962
49f2d5d
2412b2c
64a63ee
022e4f7
8962f70
d8bd307
c86479c
e7d6ff0
57366ea
69156a1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a temporary addition due to lack of nullable types support within numpy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have an issue filed to resolve this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's a workaround for this error, why do we start off by attempting to use numpy? Are there downsides to just using
y.unique()
in all cases instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is tied to this: #3649
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether we want to file an issue with Woodwork for the ability to do this? Basically I wanted to use the woodwork table accessor to assign a handful of columns to an existing dataframe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've filed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the target is being imputed, it seems safe to assume there will be no null values in it. It should be safe to change the data type to Integer then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pandas is working on a Float64 datatype to go hand in hand with Int64 nullable integers and nullable booleans. When that becomes a thing, we can get rid of this as Woodwork will probably infer Float64 like it is the other nullable types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have an issue filed to track this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem here is that pandas' interpolate won't run on the new nullable integer. They are tracking this and I commented on the relevant issue pandas-dev/pandas#40252
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reinitializes the dataframe with the original schema excluding
IntegerNullable
andBooleanNullable
types so that they can be reinferred post imputationThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to get rid of this because of the casting to float and interpolation was trying to overwrite the new float dtype with the original Int64 dtype. We might need to add some testing for this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Covered as part of
test_numeric_only_input
andtest_imputer_bool_dtype_object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was happening here was that the delayed_features were half np.NaN and half pd.NA. re-init'ing standardized the columns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we reuse any part of the initial schema or use what we know about the dtypes of these features here to reduce the amount of type reinference this might introduce?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introduction of nulls makes initialization necessary here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A function that helps with some components not accepting an
IntegerArray
or being unable to cast values from afloat
to anint