Relative dates in deadlines and scheluded for before and after #149

dancn · 2020-04-24T09:48:42Z

Backward compatible improvement, org-read-date support a super-set of
the previous function org-time-string-to-absolute.

Should be also an easy solution for #59.

alphapapa · 2020-05-01T11:50:15Z

Thanks, this looks like a nice improvement. I will look at it more closely when I have some time, hopefully soon.

nivekuil · 2020-07-29T23:30:37Z

+1, I use this patch locally and it's quite convenient.

pkazmier · 2020-12-09T01:46:46Z

Yes, I, too, think this would be incredibly useful, so much so, I submitted the exact same PR without realizing this one existed!

dancn · 2021-04-26T07:09:35Z

After one year I re-based the branch for my convenience, hopefully will also speed up the review and merge.

real-or-random · 2021-09-23T12:46:41Z

It would be great to see this merged!

alphapapa · 2021-09-24T01:28:27Z

Thanks for the ping and your patience.

alphapapa

Thanks for your patience. I think this shouldn't need much more before it can be merged.

Also, would you add tests for this, please? (i.e. in the test suite, not just that Org file)

alphapapa · 2021-09-24T01:32:19Z

README.org

@@ -191,7 +191,7 @@ These selectors take one argument alone, or multiple arguments in a list.
 +  =:category= :: Group items that match any of the given categories.  Argument may be a string or list of strings.
 +  =:children= :: Select any item that has child entries.  Argument may be ~t~ to match if it has any children, ~nil~ to match if it has no children, ~todo~ to match if it has children with any to-do keywords, or a string to match if it has children with certain to-do keywords.  You might use this to select items that are project top-level headings.  Be aware that this may be very slow in non-daily/weekly agenda views because of its recursive nature.
 +  =:date= :: Group items that have a date associated. Argument can be =t= to match items with any date, =nil= to match items without a date, or =today= to match items with today’s date. The =ts-date= text-property is matched against.


Should other selectors, like :date, also support this?

Thanks for your patience. I think this shouldn't need much more before it can be merged.

Thanks for the review!

Also, would you add tests for this, please? (i.e. in the test suite, not just that Org file)

Just added a quick test (not pushed yet). It fails, I guess that org-read-date is not aware of org-super-agenda-test-date so relative date specification can not be tested without further mocks. Do you have some suggestion on how to do that?

:date does not support arbitrary dates yet (only static: any, none, today), so relative ones are a double step!

Thanks for your patience. I think this shouldn't need much more before it can be merged.

Thanks for the review!

FYI, feel free to ping me more often in the future. I didn't intend to ignore this for a year; I just hadn't thought about working on org-super-agenda for a while, since I didn't need to change anything in it for my own sake, and I have a number of other projects that occupy my free time.

Also, would you add tests for this, please? (i.e. in the test suite, not just that Org file)

Just added a quick test (not pushed yet). It fails, I guess that org-read-date is not aware of org-super-agenda-test-date so relative date specification can not be tested without further mocks. Do you have some suggestion on how to do that?

I guess you'll have to look in the Org source code, find the appropriate function, and redefine it locally in the test using cl-letf.

:date does not support arbitrary dates yet (only static: any, none, today), so relative ones are a double step!

As you can tell, I haven't worked on this package for a while. :) We should probably fix that too, though maybe not in this PR.

alphapapa · 2021-09-24T01:32:49Z

org-super-agenda.el

-`org-time-string-to-absolute' can process."
+DATE', where DATE is a date string that `org-read-date' can
+process.  Note that relative dates are supported, e.g. `before
+3d' means in the next two days."


The +3d here should be in a string, right?

Yes, do you think that is not clear?

The part in the backtick-apostrophe quote indicates Lisp code, i.e. like (:scheduled (before "+3d")). Without the string, it wouldn't be valid, e.g. (:scheduled (before +3d)). So the +3d should appear as a string, I think.

alphapapa · 2021-09-24T01:33:16Z

org-super-agenda.el

-`org-time-string-to-absolute' can process."
+DATE', where DATE is a date string that `org-read-date' can
+process.  Note that relative dates are supported, e.g. `before
+3d' means in the next two days."


See previous comment. :)

dancn · 2021-10-11T08:27:56Z

Hello,
I tried to add some tests with the last push, but failed. Please comment/suggest on the new tentative. Thanks

alphapapa · 2021-10-11T15:54:26Z

It shouldn't be necessary to use advice for this. See

org-super-agenda/test/test.el

Line 214 in 369a4cd

(cl-defmacro org-super-agenda-test--with-mock-functions (fns &rest body)

Also, FYI, the advice you wrote uses the old-style advice. When writing advice, you should instead use the new-style nadvice library that uses add-function and advice-add. See the Elisp manual.

Backward compatible improvement, org-read-date support a super-set of the previous function org-time-string-to-absolute. The tests are working, but hugly hacks to force org-read-date to compute a relative date to a fixed date.

dancn · 2021-10-15T14:54:23Z

Another try here! I found out out to get relative date to a fixed date... the test code is not very lispy but works and covers the obvious cases.

dancn · 2021-10-28T12:00:51Z

@alphapapa or anybody interested, please have a look at the patch and request changes or improve it! Thanks!

eugr · 2022-01-24T00:59:15Z

Any updates on this? Anything preventing this from being merged? This would be a mega-useful feature as there is no good workaround for this currently.

DominikMendel · 2022-10-17T00:23:34Z

I did this as a local work around to adjust for the number of days. Hope it helps anyone else. It's a little janky.

(defun my/get-time-string-today-offset (dayOffSet)
  (format-time-string "%Y-%m-%d %H:%M" (+ (string-to-number (format-time-string "%s" (current-time))) (* 86400 dayOffSet))))

And call it like this:

  (let ((date (my/get-time-string-today-offset 5)))
....
`( ...
:scheduled (after ,date)
)

alphapapa · 2022-10-17T14:09:13Z

Any updates on this? Anything preventing this from being merged? This would be a mega-useful feature as there is no good workaround for this currently.

@eugr What prevents it from being merged is chiefly my lack of time to work on it. I don't have as much to spend on this project as I used to.

Besides that, there are issues of code quality, tests to be reviewed, etc. that must be addressed before it can be merged. Some of them I have mentioned to the PR's author in comments, so in that respect, the PR is waiting on him to address them, and then on me to re-review and confirm that it's appropriate for merging.

#225 is also a possibility for merging, but it also needs to be polished and re-reviewed, and its author has not responded to my last comment.

Of course, if either of these PRs works for you, you're free to use their code as-is right now.

dancn force-pushed the relative-dates branch from bc1a96e to 802cb3c Compare April 24, 2020 13:18

dancn changed the title ~~Relative dates in dedalines and scheluded for before and after~~ Relative dates in deadlines and scheluded for before and after Apr 24, 2020

alphapapa self-assigned this May 1, 2020

alphapapa added this to the 1.3 milestone May 1, 2020

This was referenced Dec 9, 2020

Add relative dates to :deadline and :scheduled #180

Closed

Proposal to include time ranges in :scheduled and :deadline selectors #169

Closed

pkazmier mentioned this pull request Dec 30, 2020

Grouping items using :deadline (before ..) is not working #187

Closed

dancn force-pushed the relative-dates branch from 802cb3c to 018a764 Compare April 26, 2021 06:50

alphapapa added the enhancement label Sep 24, 2021

alphapapa mentioned this pull request Sep 24, 2021

[WIP] Add timestamp selector. #154

Open

alphapapa requested changes Sep 24, 2021

View reviewed changes

dancn force-pushed the relative-dates branch from 018a764 to 369a4cd Compare October 8, 2021 13:09

dancn force-pushed the relative-dates branch from 369a4cd to 4eee6a6 Compare October 15, 2021 14:48

alphapapa mentioned this pull request Jul 9, 2022

Relative dates support. #225

Open

alphapapa mentioned this pull request Nov 20, 2022

Can't use simple lisp expressions for :deadline #235

Closed

alphapapa removed this from the 1.3 milestone Sep 23, 2023

alphapapa added this to the 1.4 milestone Sep 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Relative dates in deadlines and scheluded for before and after #149

Relative dates in deadlines and scheluded for before and after #149

dancn commented Apr 24, 2020

alphapapa commented May 1, 2020

nivekuil commented Jul 29, 2020

pkazmier commented Dec 9, 2020

dancn commented Apr 26, 2021

real-or-random commented Sep 23, 2021

alphapapa commented Sep 24, 2021

alphapapa left a comment

alphapapa Sep 24, 2021

dancn Sep 24, 2021

alphapapa Sep 24, 2021

alphapapa Sep 24, 2021

dancn Sep 24, 2021

alphapapa Sep 24, 2021

alphapapa Sep 24, 2021

dancn commented Oct 11, 2021

alphapapa commented Oct 11, 2021

dancn commented Oct 15, 2021

dancn commented Oct 28, 2021

eugr commented Jan 24, 2022

DominikMendel commented Oct 17, 2022

alphapapa commented Oct 17, 2022

Relative dates in deadlines and scheluded for before and after #149

Are you sure you want to change the base?

Relative dates in deadlines and scheluded for before and after #149

Conversation

dancn commented Apr 24, 2020

alphapapa commented May 1, 2020

nivekuil commented Jul 29, 2020

pkazmier commented Dec 9, 2020

dancn commented Apr 26, 2021

real-or-random commented Sep 23, 2021

alphapapa commented Sep 24, 2021

alphapapa left a comment

Choose a reason for hiding this comment

alphapapa Sep 24, 2021

Choose a reason for hiding this comment

dancn Sep 24, 2021

Choose a reason for hiding this comment

alphapapa Sep 24, 2021

Choose a reason for hiding this comment

alphapapa Sep 24, 2021

Choose a reason for hiding this comment

dancn Sep 24, 2021

Choose a reason for hiding this comment

alphapapa Sep 24, 2021

Choose a reason for hiding this comment

alphapapa Sep 24, 2021

Choose a reason for hiding this comment

dancn commented Oct 11, 2021

alphapapa commented Oct 11, 2021

dancn commented Oct 15, 2021

dancn commented Oct 28, 2021

eugr commented Jan 24, 2022

DominikMendel commented Oct 17, 2022

alphapapa commented Oct 17, 2022