Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement phone verification service #188

Open
wants to merge 54 commits into
base: master
Choose a base branch
from
Open

Implement phone verification service #188

wants to merge 54 commits into from

Conversation

BambanzaJuniorThe2nd
Copy link
Contributor

Related Issues

List of issues fixed by this pull request

Fixes #2

Description

Provide an overview of the changes in this pull request
This task is aimed at implementing a service for verifying phone numbers through SMS messages sent to donors.

@BambanzaJuniorThe2nd BambanzaJuniorThe2nd added the enhancement New feature or request label Dec 8, 2020
@BambanzaJuniorThe2nd BambanzaJuniorThe2nd self-assigned this Dec 8, 2020
@habbes habbes removed this from the Improve donor experience milestone Dec 12, 2020
@BambanzaJuniorThe2nd
Rename methods sendSms and confirmSms in module VerificationService t…
076c5d8 
…o sendVerificationSms and confirmVerificationSms, respectiviely
@BambanzaJuniorThe2nd
Rename method confirmVerficationSms to confirmVerificationCode
4b126d2
@BambanzaJuniorThe2nd
Create error message for when there's no record corresponding to a sp…
62a9341 
…ecific verification code
@BambanzaJuniorThe2nd
Implement user service method for verifying donor by setting isPhoneV…
e31f4d3 
…erified field to true
@BambanzaJuniorThe2nd
Implement user service method for verifying donor by setting isPhoneV…
9d03e4c 
…erified field to true
@BambanzaJuniorThe2nd
Update sms format for phone verification
83c3ae6
@BambanzaJuniorThe2nd
Commit master branch changes
ec896a3
@BambanzaJuniorThe2nd
Commit master branch changes
94e579b
@BambanzaJuniorThe2nd
Create event emitters and listeners for when a user is created or act…
2605035 
…ivated
@BambanzaJuniorThe2nd
implement error handling cases for error codes phoneAlreadyVerfied an…
319f286 
…d phoneVerificationRecordNotFound
@BambanzaJuniorThe2nd
Resolve error 'Property getAllBeneficiaries does not exist'
4cb51bf
@BambanzaJuniorThe2nd
Return corresponding verification record after verifying phone number
6fc8075
@BambanzaJuniorThe2nd
Design and implement phone verification page
e8d9113
@BambanzaJuniorThe2nd
Create a route entry for the verify-phone page
9733a65
@BambanzaJuniorThe2nd
Display phone verification-related error message on page in addition …
c3383ff 
…to displaying it in popup dilaog
@BambanzaJuniorThe2nd
Redirect user to home page upon clicking Return home button
d3ebd1f
@BambanzaJuniorThe2nd
Use await when invoking bitly link shortener method shortenLink
b532cfc
@BambanzaJuniorThe2nd
Update verified user projection label from VERIFIED_DONOR_PROJECTION …
27cb7cc 
…to VERIFIED_USER_PROJECTION
@BambanzaJuniorThe2nd
Display appropriate error message on verify-phone page
8fb2b7c
@BambanzaJuniorThe2nd
Exclude code when fetching phone verification records
679acd2
@BambanzaJuniorThe2nd
Create endpoint for fetching specific phone verification record
b717950
@BambanzaJuniorThe2nd
Update utility method generateId to take in a size parameter
e21c04c
@BambanzaJuniorThe2nd
Redefine method confirmVerificationCode to take in and id and code
0624abe
@BambanzaJuniorThe2nd
Redefine method confirmVerifcationCode to be more error-specific
32322ae
@BambanzaJuniorThe2nd
Redefine endpoint for confirming verification code to be of HTTP PUT …
0e5f2f2 
…status
@BambanzaJuniorThe2nd
Create a frontend verifications service method to fetch speciclear
5a9087c
@BambanzaJuniorThe2nd
Implement logic for submitting phone verification code
32d9d33
@BambanzaJuniorThe2nd
Only pass the phone verification code in the request body when hittin…
920b662 
…g the phone verification endpoint
@BambanzaJuniorThe2nd
Throw phone already verified error in method getById from service Pho…
a105384 
…neVerificationService
@BambanzaJuniorThe2nd
Use base_url in link in getPhoneVerificationLink
9417726
@BambanzaJuniorThe2nd
Remove access to state field message from verify-phone view
c2f10b8
@BambanzaJuniorThe2nd
Implement new verifications service method for creating phone verific…
80af806 
…ation records
@BambanzaJuniorThe2nd
Create another a db-specific type that includes field code in phone v…
62e1be6 
…erification service docs
@BambanzaJuniorThe2nd
Implement validators and validation schemas for service phone-verific…
6e7b917 
…ation
@BambanzaJuniorThe2nd
Pass user object in body when creating phone verification record
ba3e543
@BambanzaJuniorThe2nd
Pass user phone in body when creating phone verification records
5ca422c
@BambanzaJuniorThe2nd
Remove event emitter emitUserCreated in User service method create
6bac957
@BambanzaJuniorThe2nd
Remove event emitter emitUserCreated in User service method create
24de1fc
@BambanzaJuniorThe2nd
Redirect user to verify their phone number after signing up
45eda17
@BambanzaJuniorThe2nd
Remove event emitter emitUserActivated in User service method activat…
6efa0e2 
…eMiddleman
@BambanzaJuniorThe2nd
Pass phone to User-service method create upon hitting endpoint for cr…
6f6ac31 
…eating phone verification records
@BambanzaJuniorThe2nd
Hide sign-up dialog upon redirection to verify-phone page
1840802
@BambanzaJuniorThe2nd
Fetch phone verification record only if not available in state
cf7213c
@BambanzaJuniorThe2nd
Reformat phone verification sms to be shorter
c74011e
@BambanzaJuniorThe2nd
Fetch phone verification record only if not available in state
380eb14
@BambanzaJuniorThe2nd
Implement Phone Verification service method to resend new verificatio…
3ce4efa 
…n code
@BambanzaJuniorThe2nd
Create endpoint for requesting resend of phone verification code
ef351ae
@BambanzaJuniorThe2nd
Implement action for resending phone verification code
a6bce31
@BambanzaJuniorThe2nd
Update confirmVerificationCodeInputSchema to allow code as input
242d6b4
@BambanzaJuniorThe2nd
Throw Invalid phone verification code error if supplied code does not…
3472666 
… match with code in corresponding record
@BambanzaJuniorThe2nd
Create an invalidPhoneVerificationCode error code
012c1cb
@BambanzaJuniorThe2nd
Update link in getPhoneVerificationLink
9d6a2d8
@BambanzaJuniorThe2nd
Commit implementation of Verifications service method resendPhoneVeri…
728e902 
…ficationCode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@habbes habbes Awaiting requested review from habbes

At least 1 approving review is required to merge this pull request.

Assignees

@BambanzaJuniorThe2nd BambanzaJuniorThe2nd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Phone verification backend
2 participants
@BambanzaJuniorThe2nd @habbes