Address PR comments

server/src/core/app.ts

@@ -108,7 +108,7 @@ export interface AppConfig {
    */
   googleClientId: string;
   sendgridApiKey: string;
-  socialReliefEmail: string;
+  emailSender: string;
 };
 
 export function loadAppConfigFromEnv(env: { [key: string]: string }): AppConfig {
@@ -137,6 +137,6 @@ export function loadAppConfigFromEnv(env: { [key: string]: string }): AppConfig
     statsComputationInterval: (env.STATS_COMPUTATION_INTERVAL && Number(env.STATS_COMPUTATION_INTERVAL)) || 1,
     googleClientId: env.GOOGLE_CLIENT_ID,
     sendgridApiKey: env.SENDGRID_API_KEY || '',
-    socialReliefEmail: env.SOCIAL_RELIEF_EMAIL || '[email protected]'
+    emailSender: env.EMAIL_SENDER || 's'
   };
 }

server/src/core/bootstrap.ts

@@ -6,7 +6,7 @@ import { createDbConnectionFailedError } from './error';
 import { DonationDistributions } from './distribution';
 import { SystemLocks } from './system-lock';
 import { AtSmsProvider } from './sms';
-import { sendgridEmailProvider } from './email';
+import { SendGridEmailProvider } from './email';
 import { Invitations } from './invitation';
 import { EventBus } from './event';
 import { UserNotifications } from './user-notification';
@@ -62,9 +62,9 @@ export async function bootstrap(config: AppConfig): Promise<App> {
     apiKey: config.atApiKey,
     sender: config.atSmsSender
   });
-  const emailProvider = new sendgridEmailProvider({
+  const emailProvider = new SendGridEmailProvider({
     apiKey: config.sendgridApiKey,
-    socialReliefEmail: config.socialReliefEmail
+    emailSender: config.emailSender
   });
 
   // starts listening to events when instantiated

server/src/core/email/index.ts

@@ -1,2 +1,2 @@
 export * from './types';
-export { sendgridEmailProvider } from './sendgrid-email-provider';
+export { SendGridEmailProvider } from './sendgrid-email-provider';

server/src/core/email/sendgrid-email-provider.ts

@@ -2,24 +2,24 @@ import { EmailProvider } from './types';
 import { rethrowIfAppError, createEmailDeliveryFailedError, createSendGridApiError } from '../error';
 import sgMail = require('@sendgrid/mail');
 
-export interface sendgridEmailProviderArgs {
+export interface SendGridEmailProviderArgs {
   apiKey: string,
-  socialReliefEmail: string
+  emailSender: string
 };
 
-export class sendgridEmailProvider implements EmailProvider{
-  private socialReliefEmail: string;
+export class SendGridEmailProvider implements EmailProvider{
+  private emailSender: string;
 
-  constructor(args: sendgridEmailProviderArgs) {
+  constructor(args: SendGridEmailProviderArgs) {
     sgMail.setApiKey(args.apiKey);
-    this.socialReliefEmail = args.socialReliefEmail;
+    this.emailSender = args.emailSender;
   }
 
   async sendEmail(to: string, message: string): Promise<void> {
     try {
       const res = await sgMail.send({
         to,
-        from: this.socialReliefEmail,
+        from: this.emailSender,
         subject: 'Social Relief Notification',
         text: message,
       });