Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable focus outline on navigation link #379

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Disable focus outline on navigation link #379

merged 2 commits into from
Nov 14, 2024

Conversation

kr8n3r
Copy link
Contributor

@kr8n3r kr8n3r commented Nov 14, 2024

As we already apply a focus state to the link child element, there is no need for an additional focus outline on the link itself that User Agents apply as default

Before
Screenshot 2024-11-14 at 09 59 15

After
Screenshot 2024-11-14 at 09 59 29

As we already apply a focus state to the link child element, there is no need for an additional focus outline on the link itself that User Agents apply as default
Copy link

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted

@kr8n3r kr8n3r merged commit f612183 into main Nov 14, 2024
3 checks passed
@kr8n3r kr8n3r deleted the fix-nav-link-focus branch November 14, 2024 10:09
kr8n3r added a commit that referenced this pull request Nov 14, 2024
## Fixes

- [Disable focus outline on navigation link](#379)
- [Warning text extension fix for govuk-frontend v5.7.1](#378)
@kr8n3r kr8n3r mentioned this pull request Nov 14, 2024
maverickvi pushed a commit to hmrc/tech-docs-gem that referenced this pull request Nov 14, 2024
## Fixes

- [Disable focus outline on navigation link](alphagov#379)
- [Warning text extension fix for govuk-frontend v5.7.1](alphagov#378)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants