Introduce a custom module to silence dart sass warnings #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, we have defined a custom SassWarningSupressor module that overrides the warn method so that we can ignore messages containing 'sass' or 'dart-sass' only. This is needed so that we can avoid sass warnings in downstream projects.
|
The alternative option at #365 doesn't work well. |
|
What do you make the the test failures @marcotranchino? |
The test failures are intermittent... all the checks have passed now, @huwd I am fixing the intermittent failures with a separate PR merging into the branch use-govuk-frontend-v5 at #368 |
chao-xian
approved these changes
Sep 26, 2024
|
Thanks for the review, @chao-xian ! |
|
Happy to merge this into your branch, @kr8n3r ? |
marcotranchino
deleted the
use-govuk-frontend-v5-silence-dart-sass-warnings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we have defined a custom SassWarningSupressor module that overrides the warn method so that we can ignore messages containing 'sass' or 'dart-sass' only.
This is needed so that we can avoid sass warnings in downstream projects.