Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump rails from 7.2.2.1 to 8.0.1 #3435

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Bump rails from 7.2.2.1 to 8.0.1 #3435

merged 1 commit into from
Jan 6, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 16, 2024 •
edited
Loading

Bumps rails from 7.2.2.1 to 8.0.1.

Release notes

Sourced from rails's releases.

8.0.1

Active Support

  • Fix a bug in ERB::Util.tokenize that causes incorrect tokenization when ERB tags are preceeded by multibyte characters.

    Martin Emde

  • Restore the ability to decorate methods generated by class_attribute.

    It always has been complicated to use Module#prepend or an alias method chain to decorate methods defined by class_attribute, but became even harder in 8.0.

    This capability is now supported for both reader and writer methods.

    Jean Boussier

Active Model

  • No changes.

Active Record

  • Fix removing foreign keys with :restrict action for MySQ

    fatkodima

  • Fix a race condition in ActiveRecord::Base#method_missing when lazily defining attributes.

    If multiple thread were concurrently triggering attribute definition on the same model, it could result in a NoMethodError being raised.

    Jean Boussier

  • Fix MySQL default functions getting dropped when changing a column's nullability.

    Bastian Bartmann

  • Fix add_unique_constraint/add_check_constraint/add_foreign_key to be revertible when given invalid options.

    fatkodima

  • Fix asynchronous destroying of polymorphic belongs_to associations.

    fatkodima

  • Fix insert_all to not update existing records.

    fatkodima

... (truncated)

Commits
  • cf6ff17 Preparing for 8.0.1 release
  • 0bba3c2 Merge pull request #53936 from jsharpify/jsharpify/prism-parsing
  • 8521b99 [RF-DOCS] Update Rails Testing Guide [ci skip] (#53872)
  • dbe61a7 Merge pull request #53907 from p8/guides/fix-canonical
  • f8d559d [RF-DOCS] Asset Pipeline Documentation (Propshaft) [ci-skip] (#53875)
  • 2ae1d69 [RF-DOCS] Solid Cache updates in Caching with Rails: An Overview [ci-skip] (...
  • 85bde83 Merge pull request #53926 from Ridhwana/Ridhwana/solid-queue
  • c167cbe Merge pull request #53941 from byroot/rack-server-protocol
  • 656e209 Merge pull request #53940 from mjankowski/rdoc-link-to-add-check-constraint
  • b9608a6 Merge pull request #53937 from fatkodima/mysql-fix-remove-foreign-key-restrict
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Dec 16, 2024
@dependabot dependabot bot mentioned this pull request Dec 16, 2024
Closed
@github-actions GitHub Actions
Copy link

This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@dependabot dependabot bot force-pushed the dependabot/bundler/rails-8.0.1 branch 3 times, most recently from c99fac2 to c479b89 Compare December 18, 2024 16:36
@yndajas yndajas marked this pull request as draft December 19, 2024 11:20
@yndajas
Copy link
Member

yndajas commented Dec 19, 2024

Trello

@dependabot dependabot bot force-pushed the dependabot/bundler/rails-8.0.1 branch 3 times, most recently from 1d3b16d to b3fd07c Compare December 27, 2024 08:41
@dependabot dependabot bot force-pushed the dependabot/bundler/rails-8.0.1 branch 2 times, most recently from b4aca16 to 529a7da Compare January 2, 2025 08:39
@dependabot @mike3985
Bump rails from 7.2.2.1 to 8.0.1
346c7ff 
Bumps [rails](https://github.com/rails/rails) from 7.2.2.1 to 8.0.1.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](rails/rails@v7.2.2.1...v8.0.1)

---
updated-dependencies:
- dependency-name: rails
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@mike3985 mike3985 force-pushed the dependabot/bundler/rails-8.0.1 branch from 529a7da to 346c7ff Compare January 3, 2025 16:46
@mike3985 mike3985 marked this pull request as ready for review January 3, 2025 16:46
@mike3985 mike3985 merged commit 139b000 into main Jan 6, 2025
15 checks passed
@mike3985 mike3985 deleted the dependabot/bundler/rails-8.0.1 branch January 6, 2025 09:30
@hannako
Copy link
Contributor

hannako commented Jan 7, 2025

I was just grepping alphagov to see which teams had started rails 8 upgrades, and came across this PR - and noted that the https://github.com/alphagov/signon/blob/main/config/application.rb#L24 hadn't been updated. I'm sure you're across it, but just pinging you as I noticed it on my travels!

@mike3985
Copy link
Contributor

mike3985 commented Jan 7, 2025

I was just grepping alphagov to see which teams had started rails 8 upgrades, and came across this PR - and noted that the https://github.com/alphagov/signon/blob/main/config/application.rb#L24 hadn't been updated. I'm sure you're across it, but just pinging you as I noticed it on my travels!

Thanks @hannako. Yeah, Ynda pointed this out to me yesterday. It's only one of a few half-done Rails upgrades that're on my to-do list to fix 👍

@mike3985 mike3985 mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike3985 mike3985 mike3985 approved these changes

Assignees
No one assigned
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yndajas @hannako @mike3985