PP-12395: Cypress test for API keys landing page #4392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oswaldquek
force-pushed
the
PP-12395-api-keys-landing-page-cypress-test
branch
from
637221f to
d0dc26b
Compare
DomBelcher
reviewed
Dec 18, 2024
Comment on lines
+68
to
+80
| cy.get('#api-keys').should('have.text', 'API keys') | ||
| cy.get('.service-settings-pane') | ||
| .find('a') | ||
| .contains('Create a new API key') | ||
| .should('exist') | ||
| cy.get('.service-settings-pane') | ||
| .find('h2') | ||
| .contains('Active test API keys (2)') | ||
| .should('exist') | ||
| cy.get('.service-settings-pane') | ||
| .find('a') | ||
| .contains('Show revoked API keys') | ||
| .should('exist') |
There was a problem hiding this comment.
This should probably test for more than just these bits of text - it should test that the summary cards are shown with the correct content - this could be in a separate test though to aid readability
There was a problem hiding this comment.
Good call - test added
oswaldquek
commented
Dec 18, 2024
Comment on lines
+108
to
+109
| verifySummaryCard(0, apiKeys[0]) | ||
| verifySummaryCard(1, apiKeys[1]) |
There was a problem hiding this comment.
This is one line less than a for-loop so don't ask me to use a for-loop 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cypress tests for #4385