PP-12444 refactor settings layout #4384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlsteers
force-pushed
the
pp-12444/ticket_review_comments
branch
from
c6692e1 to
716ffa8
Compare
- add `service-settings-pane` css class to enforce consistent width across all settings views - remove `hint-and-body-width` css class - update base settings layout to include the back link and error summary macros - update existing views to conform with new layout behaviour - refactor email notifications custom paragraph controller to match common code style - fix layout bug where long words would break out of the system messages component - fix layout bug where long task names would cause the task status to jump onto multiple lines - fix controller bug where entering a welsh service name that fails validation would cause the 'remove welsh service name' button to unsuccessfully attempt to remove the english service name
nlsteers
force-pushed
the
pp-12444/ticket_review_comments
branch
from
716ffa8 to
40f2af5
Compare
oswaldquek
requested changes
Dec 13, 2024
Comment on lines
+40
to
+41
| text: "Send payment confirmation emails" | ||
| }, |
Comment on lines
40
to
42
| hint: { | ||
| text: 'Users can choose to enter an email address – if they do, they can receive notifications' | ||
| } |
There was a problem hiding this comment.
According to proper json formatting the indent should be
a: {
b: 'whatever'
}
so lines 41-42 should be indented to the right.
Comment on lines
52
to
53
| text: 'Users do not have the option to enter an email address – they will not receive notifications' | ||
| } |
Comment on lines
27
to
28
| text: 'Users must enter an email address to complete a payment – they can receive notifications' | ||
| } |
Comment on lines
34
to
36
| hint: { | ||
| text: 'Users can choose to enter an email address – if they do, they can receive notifications' | ||
| } |
Comment on lines
+45
to
+46
| text: "Permission level", | ||
| classes: "govuk-fieldset__legend--s" |
|
|
||
| {{ govukButton({ | ||
| text: "Send invitation email" |
Comment on lines
+14
to
+15
| idPrefix: "confirmRemoveUser", | ||
| name: "confirmRemoveUser", |
Comment on lines
+19
to
+22
| text: "Are you sure you want to remove " + email + "?", | ||
| isPageHeading: true, | ||
| classes: "govuk-fieldset__legend--l" | ||
| } |
Comment on lines
+25
to
+35
| text: "They will no longer have access to this service." | ||
| }, | ||
| items: [ | ||
| { | ||
| value: "yes", | ||
| text: "Yes", | ||
| attributes: {'data-cy': 'yes-radio'} | ||
| }, | ||
| { | ||
| value: "no", | ||
| text: "No", |
oswaldquek
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
service-settings-panecss class to enforce consistent width across all settings viewshint-and-body-widthcss classSCREENS