PP-12444 simplified account stripe onboarding tasks cypress tests #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cypress tests for the following tasks: - company number - vat number - service director - small improvement to multi-select enhancement that refocuses the open button for the drop down when clicking the close button (maintains current position when navigating by keyboard) - case typo in service switcher template (DSv5)
oswaldquek
approved these changes
Dec 5, 2024
| setStubs({}, [ | ||
| stripeAccountSetupStubs.getServiceAndAccountTypeStripeSetupSuccess({ | ||
| serviceExternalId: SERVICE_EXTERNAL_ID, | ||
| accountType: LIVE_ACCOUNT_TYPE |
There was a problem hiding this comment.
Might make for easier reading if vatNumber: false is set here.
| setStubs({}, [ | ||
| stripeAccountSetupStubs.getServiceAndAccountTypeStripeSetupSuccess({ | ||
| serviceExternalId: SERVICE_EXTERNAL_ID, | ||
| accountType: LIVE_ACCOUNT_TYPE |
There was a problem hiding this comment.
Might make for easier reading if director: false was set here
nlsteers
deleted the
pp-12444/stripe_details_simplified_account_settings_cypress_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
SCREENS
Screen.Recording.2024-12-05.at.16.20.52.mov