Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-13297 clickable text, layout, and Oxford commas #4375

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

james-peacock-gds
Copy link
Contributor

  • The following changes are made to the Change Permissions page and Invite user page:
    • Fix a layout problem relating to hint text
    • Make radio button labels clickable
    • Add commas to role explanation text as indicated in design.

Screenshot before fix, showing layout problem with the hint text for 'View only'

Screenshot 2024-12-04 at 14-34-00 Settings - Team members - Change permission - GOV UK Pay

Screenshot for Change Permission (moto service)

Screenshot 2024-12-05 at 10 16 17

Screenshot for Invite User (moto service)

Screenshot 2024-12-05 at 10 16 06

Screenshot for Change Permission (non-moto service)

Screenshot 2024-12-05 at 10 17 36

Screenshot for Invite User (non-moto service)

Screenshot 2024-12-05 at 10 17 47

Copy link
Contributor

@DomBelcher DomBelcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james-peacock-gds james-peacock-gds merged commit 9092ade into master Dec 5, 2024
13 of 14 checks passed
@james-peacock-gds james-peacock-gds deleted the PP-13297-layout-corrections branch December 5, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants