Pp 12020 upgrade to dsv5 #4330
Merged
Pp 12020 upgrade to dsv5 #4330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iqbalgds
force-pushed
the
pp-12020-upgrade-to-dsv5
branch
2 times, most recently
from
4e9ce5a to
8f7f3a2
Compare
iqbalgds
force-pushed
the
pp-12020-upgrade-to-dsv5
branch
from
8f7f3a2 to
40e5c0e
Compare
| @@ -77,7 +77,6 @@ | |||
| document.getElementById('bank-account-form').addEventListener('submit', function () { | |||
| submitButton.setAttribute('disabled', 'true') | |||
| submitButton.setAttribute('aria-disabled', 'true') | |||
| submitButton.setAttribute('class', 'govuk-button govuk-button--disabled') | |||
There was a problem hiding this comment.
I presume that the behaviour is still the same after removing this?
There was a problem hiding this comment.
Yes - I tested this by creating a little test.
Good questions.
app/views/webhooks/message.njk
Outdated
| @@ -54,7 +54,7 @@ | |||
| }) }} | |||
|
|
|||
| <div class="govuk-body"> | |||
| <details class="govuk-details" data-module="govuk-details"> | |||
| <details class="govuk-details" > | |||
There was a problem hiding this comment.
Tiny thing - there's a stray space in this element.
|
Just two small comments and the branch has conflicts. Other than that it all looks good to me. |
iqbalgds
force-pushed
the
pp-12020-upgrade-to-dsv5
branch
from
40e5c0e to
85d6f92
Compare
- Add the changes from the DSv5 release notes - https://github.com/alphagov/govuk-frontend/releases/tag/v5.0.0 - Most changes were updates to ensure compatibility with the update tag component - https://design-system.service.gov.uk/components/tag/ - Which requires all text to be in sentence case - i.e. the first letter needs to be in uppercase. - These changes have been checked using Percy. - Suppress warning about size 14 is deprecated and being removed in v6. A seperate jira has been created to look into this. - https://payments-platform.atlassian.net/browse/PP-13352
iqbalgds
force-pushed
the
pp-12020-upgrade-to-dsv5
branch
from
85d6f92 to
b1cdb77
Compare
nataliecarey
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PP-12020 Upgrade to design system v5
uppercase.
A comparison of the old tag and new tag can be seen below:
