PP-13235: Using a mountebank replacement #4287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2024
marcotranchino
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Amazing work, @nataliecarey !
I love your run-amok ! 😍
It would be good to update the README too, which still mentions Mountebank.
But that can happen later.
|
@marcotranchino Because it's a drop-in replacement for the parts of Mountebank we're using it needs some references to Mountebank - I'm expecting that the project will evolve and we'll make our own decisions about how we want these mocks to act, when we do that we can start removing references to Mountebank. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
As Mountebank is being deprecated we're moving onto our own
run-amockproject. which is a drop-in replacement for the functionality we've been using from Mountebank.(related to alphagov/pay-frontend#3913 and alphagov/pay-products-ui#2713)