Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-11681 Remove 'request' library related redundant code #4201

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

JFSGDS
Copy link
Contributor

@JFSGDS JFSGDS commented Mar 28, 2024

WHAT

Remove redundant code relating to request library as this has been replaced with new code making calls to axios library.

HOW

  • All automated tests should pass without the need to be amended.
  • Existing functionality should remain unaffected.

Copy link
Contributor

@iqbalgds iqbalgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JFSGDS JFSGDS force-pushed the PP-11681_replace_request_with_axios_remove_old_code branch 2 times, most recently from 6095215 to d2413d0 Compare April 2, 2024 12:13
… 'axios'.

- Remove 'base.client' code containing calls to 'request' library.
- Remove 'request' npm packages.
@JFSGDS JFSGDS force-pushed the PP-11681_replace_request_with_axios_remove_old_code branch from d2413d0 to ebe7a5f Compare April 2, 2024 13:26
@JFSGDS JFSGDS changed the title [DO NOT MERGE] PP-11681 Remove 'request' library related redundant code PP-11681 Remove 'request' library related redundant code Apr 3, 2024
@JFSGDS JFSGDS marked this pull request as ready for review April 3, 2024 08:07
@JFSGDS JFSGDS merged commit b80104b into master Apr 3, 2024
12 checks passed
@JFSGDS JFSGDS deleted the PP-11681_replace_request_with_axios_remove_old_code branch April 3, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants