PP-11681 Replace 'base-client' with 'axios-base-client' in 'ledger.client' #4187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iqbalgds
requested changes
Mar 4, 2024
iqbalgds
reviewed
Mar 11, 2024
| }, defaultOptions, options) | ||
| return baseClient.get(configuration) | ||
| const transactionWithAccountOverride = async function transactionWithAccountOverride (id, options = {}) { | ||
| const url = urlJoin(defaultOptions.baseUrl,'/v1/transaction', id) |
There was a problem hiding this comment.
Do we need to add a check as per line 24?
Check if the baseUrl is the default URL / coming from options object.
iqbalgds
reviewed
Mar 11, 2024
iqbalgds
reviewed
Mar 12, 2024
| await ledgerClient.transactionWithAccountOverride('id', { baseUrl: 'https://example.com' }) | ||
|
|
||
| expect(configureSpy.getCall(0).args[0]).to.equal('http://127.0.0.1:8006/v1/transaction/id?override_account_id_restriction=true') | ||
| // expect(configureSpy.getCall(0).args[0]).to.equal('https://example.com/v1/transaction/id?override_account_id_restriction=true') |
There was a problem hiding this comment.
Uncommented as suggested.
iqbalgds
previously approved these changes
Mar 12, 2024
iqbalgds
approved these changes
Mar 27, 2024
JFSGDS
force-pushed
the
PP-11681_replace_request_with_axios_ledger_client
branch
from
4ef4230 to
64a4848
Compare
JFSGDS
force-pushed
the
PP-11681_replace_request_with_axios_ledger_client
branch
from
64a4848 to
e961cf6
Compare
- Change ‘ledger.client’ methods to use ‘axios-base-client’. - Refactor call parameters initialisation. - Use ‘async/await’ syntax. - Use baseUrl from options parameter if present otherwise use default envvar.
JFSGDS
force-pushed
the
PP-11681_replace_request_with_axios_ledger_client
branch
from
e961cf6 to
4488478
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://payments-platform.atlassian.net/browse/PP-11681
WHAT
HOW
All automated tests should pass without the need to be amended.
Existing functionality should remain unaffected.