Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-11681 Replace ‘base-client’ with ‘axios-base-client' for webhooks client #4185

Merged
merged 1 commit into from
Mar 27, 2024
Merged

PP-11681 Replace ‘base-client’ with ‘axios-base-client' for webhooks client #4185

merged 1 commit into from
Mar 27, 2024

Conversation

JFSGDS
Copy link
Contributor

@JFSGDS JFSGDS commented Feb 28, 2024

https://payments-platform.atlassian.net/browse/PP-11681

WHAT

  • Change ‘webhooks.client’ methods to use ‘axios-base-client’ library.
  • Refactor call parameters initialisation.
  • Use ‘async/await’ syntax.

HOW

All automated tests should pass without the need to be amended.
Existing functionality should remain unaffected.

@JFSGDS JFSGDS marked this pull request as ready for review February 28, 2024 16:54
iqbalgds
iqbalgds requested changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@iqbalgds iqbalgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - left one comment

@JFSGDS JFSGDS requested a review from iqbalgds March 5, 2024 11:36
@iqbalgds iqbalgds changed the title PP-11681 Replace ‘base-client’ with ‘axios-base-client' PP-11681 Replace ‘base-client’ with ‘axios-base-client' for webhooks client Mar 7, 2024
iqbalgds
iqbalgds previously approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@iqbalgds iqbalgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work - we should get another pair of eyes to check this PR or the ledger client one. Before rolling out these changes across all the self service clients.

@JFSGDS JFSGDS marked this pull request as draft March 13, 2024 10:21
@JFSGDS JFSGDS requested a review from nataliecarey March 19, 2024 09:33
@JFSGDS JFSGDS requested review from iqbalgds and removed request for nataliecarey March 26, 2024 11:45
iqbalgds
iqbalgds approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@iqbalgds iqbalgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JFSGDS JFSGDS marked this pull request as ready for review March 27, 2024 10:40
@JFSGDS JFSGDS force-pushed the PP-11681_replace_request_with_axios_webhooks_client branch from 70637f8 to 5a03f8c Compare March 27, 2024 11:02
@JFSGDS
PP-11681 Update ‘webhooks.client’ with ‘axios-base-client’
60636fd 
- Change ‘webhooks.client’ methods to use ‘axios-base-client’.
- Refactor call parameters initialisation.
- Use ‘async/await’ syntax.
- Add pact tests for webhooks messages.
- Use baseUrl from options parameter if present. Otherwise use default envvar.
@JFSGDS JFSGDS force-pushed the PP-11681_replace_request_with_axios_webhooks_client branch from 5a03f8c to 60636fd Compare March 27, 2024 11:16
@JFSGDS JFSGDS merged commit 4843cd6 into master Mar 27, 2024
13 checks passed
@JFSGDS JFSGDS deleted the PP-11681_replace_request_with_axios_webhooks_client branch March 27, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iqbalgds iqbalgds iqbalgds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JFSGDS @iqbalgds