Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-11681 Replace request library with axios. #4180

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

JFSGDS
Copy link
Contributor

@JFSGDS JFSGDS commented Feb 23, 2024

https://payments-platform.atlassian.net/browse/PP-11681

WHAT

  • Initial set up for using axios as opposed to request library.
  • Use latest version of pay-js-commons library containing axios-base-client code.
  • Add clients/base files for use with axis-base-client calls.

HOW

All automated tests should pass without the need to be amended.
Existing functionality should remain unaffected.

- Initial set up.
- Use latest version of 'pay-js-commons' library containing 'axios-base-client' code.
- Add 'clients/base' files for use with axis-base-client calls.
@JFSGDS JFSGDS requested a review from iqbalgds February 23, 2024 17:41
@JFSGDS JFSGDS marked this pull request as ready for review February 26, 2024 09:33
@JFSGDS JFSGDS merged commit ef521eb into master Feb 26, 2024
12 checks passed
@JFSGDS JFSGDS deleted the PP-11681_replace_request_with_axios_initial_base branch February 26, 2024 10:22
JFSGDS added a commit that referenced this pull request Feb 28, 2024
- Initial set up.
- Use latest version of 'pay-js-commons' library containing 'axios-base-client' code.
- Add 'clients/base' files for use with axis-base-client calls.
DomBelcher pushed a commit that referenced this pull request Feb 28, 2024
- Initial set up.
- Use latest version of 'pay-js-commons' library containing 'axios-base-client' code.
- Add 'clients/base' files for use with axis-base-client calls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants