PP-10608: Correcting the number of days in transaction queries.

[nataliecarey]

WHAT

As described in PP-10608 the number of days searched on the dashboard is currently out by one. It was intentionally written (with comments describing it) but having looked deeper into it because of the use of midnight as the start of the period the extra day wasn't needed

HOW

On an account with transactions every day visit the dashboard and select "Previous 7 days" or "Previous 30 days", the query was previously showing a date range one day longer than requested for each of these categories.

[nlsteers]

Code change looks fine, there's a small accordion on the dashboard service view that explains how the values are calculated. Is this still correct or does it need updating in line with the changes in this PR?

See example image:

[nataliecarey]

Code change looks fine, there's a small accordion on the dashboard service view that explains how the values are calculated. Is this still correct or does it need updating in line with the changes in this PR?

See example image:

Good spot. I'll check, we should be updating it and I expect it's updated as a side-effect of my change but I'll confirm.

[nataliecarey]

Code change looks fine, there's a small accordion on the dashboard service view that explains how the values are calculated. Is this still correct or does it need updating in line with the changes in this PR?

See example image:

I've tested, it shows correctly in the accordion 🎉

[nlsteers]

🚀