[DO NOT MERGE] PP 11681 Replace 'request' library with 'axios' #4174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Initial set up. - Use latest version of 'pay-js-commons' library containing 'axios-base-client' code. - Add 'clients/base' files for use with axis-base-client calls.
- Change ‘products.client’ methods to use ‘axios-base-client’ library. - Refactor call parameters initialisation. - Use ‘async/await’ syntax.
- Change ‘webhooks.client’ methods to use ‘axios-base-client’. - Refactor call parameters initialisation. - Use ‘async/await’ syntax.
- Change ‘public-auth.client’ methods to use ‘axios-base-client’ library. - Refactor call parameters initialisation. - Use ‘async/await’ syntax.
- Change ‘ledger.client’ methods to use ‘axios-base-client’. - Refactor call parameters initialisation. - Use ‘async/await’ syntax.
- Change ‘connector.client’ methods to use ‘axios-base-client’. - Refactor call parameters initialisation. - Use ‘async/await’ syntax.
- Change ‘adminusers.client’ methods to use ‘axios-base-client’. - Refactor call parameters initialisation. - Use ‘async/await’ syntax. - Extend ‘instanceof RESTClientError’ test in registration controller to include a test for constructor name. This is order to identify an error thrown by the new 'axios-base-client'. Possibly needs refactoring.
- Remove ‘base.client’ code as now replaced by calls to ‘axios-base-client’. - Remove associated test.
JFSGDS
force-pushed
the
PP-11681_replace_request_lib_with_axios
branch
from
b9beb4c to
0abcba8
Compare
|
No longer required - this PR was broken down into lot's of little PRs that have merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Replace
requestlibrary withaxioshttps://payments-platform.atlassian.net/browse/PP-11681
HOW
pay-js-commonslibrary containingaxios-base-clientcodeclients/basefiles for use withaxios-base-clientcallsasync/awaitsyntax.