PP 10451 handle selfservice 504 ledger gateway timeout #4150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code change is done, but the entire historic test to do with transaction listing will need converting
…, when thrown from the Ledger service during search. Rewriting Nock based 500 and 504 integration tests in Cypress.
Convert Nock 500 and 504 Integration Test scenarios to Cypress Tests
Writing test scenario as Cypress Tests
Writing test scenario as Cypress Tests for 400, 500 and 504 responses and removing nock mocking logic
Writing transaction search test scenarios as Cypress Tests for 400, 500 and 504 responses and removing nock mock references and associated test scenarios from non-cypress integration tests.
Writing test scenario as Cypress Tests for 400, 500 and 504 responses and removing nock mocking logic
alexbishop1
requested changes
Oct 27, 2023
There was a problem hiding this comment.
It looks like some code from another story has slipped in here! Please remove it.
Logic looks basically fine and the tests are good but it looks like there’s some localised logic relating to extracting data from objects that does not look quite fine and I think some code could be removed to make it simpler.
Could you also look at squashing some of the commits together? I think we only really need one.
app/controllers/transactions/transaction-download.controller.js
Outdated
Show resolved
Hide resolved
This change is for the single service transaction search and not the all services functionality. Converting test scenarios as Cypress Tests for 400, 500 and 504 responses and removing nock mocking logic. Download of transactions list by clicking the download link was de-scoped, so no tests were written for the download functionality.
alexbishop1
requested changes
Oct 31, 2023
There was a problem hiding this comment.
Some comments below including some stuff I din’t really think about the first time round (sorry about that).
There still seems o be stuff from another story here (specifically, files app/controllers/invite-user.controller.js, app/controllers/invite-user.controller.test.js, app/views/team-members/team-member-invite.njk, test/integration/invite-users.controller.ft.test.js and test/ui/invite-user.ui.test.js). Please remove these changes from this PR.
This change is for the single service transaction search and not the all services functionality. Converting test scenarios as Cypress Tests for 400, 500 and 504 responses and removing nock mocking logic. Download of transactions list by clicking the download link was de-scoped, so no tests were written for the download functionality.
This change is for the single service transaction search and not the all services functionality. Converting test scenarios as Cypress Tests for 400, 500 and 504 responses and removing nock mocking logic. Download of transactions list by clicking the download link was de-scoped, so no tests were written for the download functionality.
This change is for the single service transaction search and not the all services functionality. Converting test scenarios as Cypress Tests for 400, 500 and 504 responses and removing nock mocking logic. Download of transactions list by clicking the download link was de-scoped, so no tests were written for the download functionality. Removed files pulled in from master for MR clarity.
This change is for the single service transaction search and not the all services functionality. Converting test scenarios as Cypress Tests for 400, 500 and 504 responses and removing nock mocking logic. Download of transactions list by clicking the download link was de-scoped, so no tests were written for the download functionality.
Convert Nock 500 and 504 Integration Test scenarios to Cypress Tests
Writing test scenario as Cypress Tests
Writing test scenario as Cypress Tests for 400, 500 and 504 responses and removing nock mocking logic
This change is for the single service transaction search and not the all services functionality. Converting test scenarios as Cypress Tests for 400, 500 and 504 responses and removing nock mocking logic. Download of transactions list by clicking the download link was de-scoped, so no tests were written for the download functionality.
This change is for the single service transaction search and not the all services functionality. Converting test scenarios as Cypress Tests for 400, 500 and 504 responses and removing nock mocking logic. Download of transactions list by clicking the download link was de-scoped, so no tests were written for the download functionality.
This change is for the single service transaction search and not the all services functionality. Converting test scenarios as Cypress Tests for 400, 500 and 504 responses and removing nock mocking logic. Download of transactions list by clicking the download link was de-scoped, so no tests were written for the download functionality.
This change is for the single service transaction search and not the all services functionality. Converting test scenarios as Cypress Tests for 400, 500 and 504 responses and removing nock mocking logic. Download of transactions list by clicking the download link was de-scoped, so no tests were written for the download functionality.
alexbishop1
approved these changes
Nov 1, 2023
olatomgds
deleted the
PP-10451-Handle_Selfservice_504_Ledger_Gateway_Timeout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
PP-10451 Handle gateway timeout error during transactions download.
This change is for the single service transaction search and not the all services functionality.
Converting test scenarios as Cypress Tests for 400, 500 and 504 responses and removing nock mocking logic.
Download of transactions list by clicking the download link was de-scoped, so no tests were written for the download functionality.
HOW
Review exception handling of the transaction listing functionality and replicate the test scenarios for the associated changes.